Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-2006][LIVE-2007] Feature: EIP-1559 #1662

Merged
merged 46 commits into from
Nov 10, 2022
Merged

[LIVE-2006][LIVE-2007] Feature: EIP-1559 #1662

merged 46 commits into from
Nov 10, 2022

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Oct 24, 2022

📝 Description

Implementing EIP-1559 for the Ethereum family transactions.
To the extent of this scope, this PR is cleaning a little bit the Ethereum coin integration and splitting its bridge into multiple files.

❓ Context

✅ Checklist

  • Test coverage // Test coverage is only done with the bot. 😞
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 5:03PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 10, 2022 at 5:03PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 10, 2022 at 5:03PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 10, 2022 at 5:03PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

🦋 Changeset detected

Latest commit: 150a775

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@ledgerhq/cryptoassets Minor
live-mobile Minor
@ledgerhq/live-common Minor
@ledgerhq/errors Minor
@ledgerhq/types-live Minor
@ledgerhq/live-cli Patch
@ledgerhq/hw-app-eth Patch
live-common-tools Patch
ledger-live-desktop Patch
@ledgerhq/devices Patch
@ledgerhq/hw-app-algorand Patch
@ledgerhq/hw-app-cosmos Patch
@ledgerhq/hw-app-helium Patch
@ledgerhq/hw-app-polkadot Patch
@ledgerhq/hw-app-solana Patch
@ledgerhq/hw-app-trx Patch
@ledgerhq/hw-transport-http Patch
@ledgerhq/hw-transport-node-ble Patch
@ledgerhq/hw-transport-node-hid-noevents Patch
@ledgerhq/hw-transport-node-hid-singleton Patch
@ledgerhq/hw-transport-node-hid Patch
@ledgerhq/hw-transport-node-speculos-http Patch
@ledgerhq/hw-transport-node-speculos Patch
@ledgerhq/hw-transport-web-ble Patch
@ledgerhq/hw-transport-webhid Patch
@ledgerhq/hw-transport-webusb Patch
@ledgerhq/hw-transport Patch
@ledgerhq/react-native-hid Patch
@ledgerhq/react-native-hw-transport-ble Patch
@ledgerhq/hw-app-btc Patch
@ledgerhq/hw-app-str Patch
@ledgerhq/hw-app-tezos Patch
@ledgerhq/hw-app-xrp Patch
@ledgerhq/hw-transport-mocker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added automation CI/CD stuff common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched labels Oct 24, 2022
@lambertkevin lambertkevin changed the base branch from develop to feat/ethereum October 24, 2022 15:43
@github-actions github-actions bot removed the automation CI/CD stuff label Oct 24, 2022
@github-actions
Copy link

github-actions bot commented Oct 24, 2022

@lambertkevin

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
v3-get-started-actual v3-get-started-diff v3-get-started-expected
v3-get-started-actual v3-get-started-diff v3-get-started-expected
v3-get-started-actual v3-get-started-diff v3-get-started-expected
v3-get-started-actual v3-get-started-diff v3-get-started-expected

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 42.88% // Head: 46.84% // Increases project coverage by +3.95% 🎉

Coverage data is based on head (150a775) compared to base (90a9fbb).
Patch coverage: 45.68% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1662      +/-   ##
===========================================
+ Coverage    42.88%   46.84%   +3.95%     
===========================================
  Files          613      681      +68     
  Lines        25652    29958    +4306     
  Branches      7036     7959     +923     
===========================================
+ Hits         11002    14035    +3033     
- Misses       14599    15866    +1267     
- Partials        51       57       +6     
Flag Coverage Δ
test 46.84% <45.68%> (+3.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ve-common/src/families/ethereum/modules/erc1155.ts 18.18% <ø> (-0.94%) ⬇️
...ive-common/src/families/ethereum/modules/erc721.ts 25.42% <ø> (-0.81%) ⬇️
...r-live-common/src/families/ethereum/transaction.ts 15.97% <10.00%> (-31.17%) ⬇️
...mmon/src/families/ethereum/getTransactionStatus.ts 19.04% <19.04%> (ø)
libs/ledger-live-common/src/walletconnect/index.ts 85.71% <28.57%> (-8.17%) ⬇️
libs/ledger-live-common/src/env.ts 72.22% <33.33%> (-2.29%) ⬇️
...live-common/src/families/ethereum/signOperation.ts 19.60% <34.21%> (-4.21%) ⬇️
...ger-live-common/src/families/ethereum/broadcast.ts 50.00% <50.00%> (ø)
...mmon/src/families/ethereum/estimateMaxSpendable.ts 53.84% <53.84%> (ø)
...bs/ledger-live-common/src/families/ethereum/gas.ts 67.30% <67.30%> (ø)
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants