Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] When deleting a token from the list of hidden tokens, it should be shown in the application #1663

Merged
merged 6 commits into from
Nov 14, 2022

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Oct 24, 2022

πŸ“ Description

  • Remove the BLACKLIST_TOKEN action in the account reducer
  • Display subAccounts only if they are not in the blacklistTokenIds list

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 4, 2022 at 2:48PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 4, 2022 at 2:48PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 4, 2022 at 2:48PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 4, 2022 at 2:48PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

πŸ¦‹ Changeset detected

Latest commit: f3523a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lvndry lvndry self-assigned this Oct 24, 2022
@github-actions github-actions bot added desktop Has changes in LLD mobile Has changes in LLM labels Oct 24, 2022
@lvndry
Copy link
Contributor Author

lvndry commented Oct 24, 2022

ORIGINAL PR: #1617

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

@lvndry

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 65.61% // Head: 43.37% // Decreases project coverage by -22.24% ⚠️

Coverage data is based on head (f3523a3) compared to base (54a06a9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1663       +/-   ##
============================================
- Coverage    65.61%   43.37%   -22.25%     
============================================
  Files           15      613      +598     
  Lines          541    25648    +25107     
  Branches       104     7046     +6942     
============================================
+ Hits           355    11125    +10770     
- Misses         181    13396    +13215     
- Partials         5     1127     +1122     
Flag Coverage Ξ”
test 43.37% <ΓΈ> (-22.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/cryptoassets/data/trc10.js
...ibs/ledgerjs/packages/cryptoassets/data/stellar.js
libs/ledgerjs/packages/cryptoassets/data/esdt.js
libs/ledgerjs/packages/cryptoassets/data/trc20.js
libs/ledgerjs/packages/cryptoassets/src/tokens.ts
libs/ledgerjs/packages/cryptoassets/data/erc20.js
libs/ledgerjs/packages/errors/src/index.ts
...s/ledgerjs/packages/cryptoassets/src/currencies.ts
...dgerjs/packages/cryptoassets/data/cardanoNative.js
libs/ledgerjs/packages/cryptoassets/data/bep20.js
... and 618 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some conflicts to solve.

@lvndry lvndry force-pushed the feat/live-3300-hidden-token-redisplay branch from 56bd72f to 2ce7421 Compare November 2, 2022 17:00
@github-actions github-actions bot added the ledgerjs Has changes in the ledgerjs open source libs label Nov 2, 2022
@lvndry lvndry deleted the feat/live-3300-hidden-token-redisplay branch November 14, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants