Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install set of apps step in mobile sync onboarding #1667

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

thomasrogerlux
Copy link
Contributor

@thomasrogerlux thomasrogerlux commented Oct 25, 2022

📝 Description

Add an extra step in the sync onboarding flow to propose installing a default set of apps to the user after genuine check. The app list in flagged, and the fallback in case of network problem is BTC, ETH and Polygon.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): FAT-542

✅ Checklist

  • Test coverage: no UI testing on mobile yet
  • Atomic delivery
  • No breaking changes

📸 Demo

N/A, see slack channels

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@thomasrogerlux thomasrogerlux requested a review from a team as a code owner October 25, 2022 09:12
@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 8:13AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 3, 2022 at 8:13AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 3, 2022 at 8:13AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 3, 2022 at 8:13AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: a375923

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Oct 25, 2022
Copy link
Contributor

@alexandremgo alexandremgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise, clean work :)

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

@thomasrogerlux

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 47.94% // Head: 47.94% // No change to project coverage 👍

Coverage data is based on head (a375923) compared to base (e890442).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1667   +/-   ##
========================================
  Coverage    47.94%   47.94%           
========================================
  Files          691      691           
  Lines        30458    30458           
  Branches      7990     7990           
========================================
  Hits         14604    14604           
+ Misses       14657    14640   -17     
- Partials      1197     1214   +17     
Flag Coverage Δ
test 47.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/errors/src/helpers.ts 29.41% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/src/tokens.ts 75.40% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thomasrogerlux thomasrogerlux merged commit 654253f into develop Nov 3, 2022
@thomasrogerlux thomasrogerlux deleted the feat/FAT-542-install-apps-sync-onboarding branch November 3, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants