Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lotties for Nano X in new BLE pairing flow #1675

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

thomasrogerlux
Copy link
Contributor

πŸ“ Description

The wrong lotties were used for the Nano X in BLE pairing flow. Replaced them with the correct one and adjusted styling

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): FAT-536

βœ… Checklist

  • Test coverage: no UI testing on mobile yet
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

N/A, see slack channels

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 2, 2022 at 4:52PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 2, 2022 at 4:52PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 2, 2022 at 4:52PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 2, 2022 at 4:52PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

πŸ¦‹ Changeset detected

Latest commit: 5f71885

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

@thomasrogerlux

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@thomasrogerlux
Copy link
Contributor Author

QA OK

@thomasrogerlux thomasrogerlux merged commit 565b3f1 into develop Nov 3, 2022
@thomasrogerlux thomasrogerlux deleted the bugfix/FAT-536-wrong-lottie-lnx-pairing branch November 3, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants