Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTG Banner in the LLM device selection #1750

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

pierrelouis-c
Copy link
Contributor

@pierrelouis-c pierrelouis-c commented Nov 3, 2022

πŸ“ Description

This PR add OTG Banner on LLM new device selection only on Android

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): FAT-533

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

OTGBanner

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 3, 2022 at 3:29PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 3, 2022 at 3:29PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 3, 2022 at 3:29PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 3, 2022 at 3:29PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2022

πŸ¦‹ Changeset detected

Latest commit: b4c48be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 43.37% // Head: 20.77% // Decreases project coverage by -22.59% ⚠️

Coverage data is based on head (b4c48be) compared to base (d3c91a5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1750       +/-   ##
============================================
- Coverage    43.37%   20.77%   -22.60%     
============================================
  Files          613        1      -612     
  Lines        25647       77    -25570     
  Branches      7046       16     -7030     
============================================
- Hits         11125       16    -11109     
+ Misses       13395       61    -13334     
+ Partials      1127        0     -1127     
Flag Coverage Ξ”
test 20.77% <ΓΈ> (-22.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/hw/getAppAndVersion.ts
libs/ledger-live-common/src/hw/getDeviceInfo.ts
...common/src/families/stellar/js-buildTransaction.ts
libs/ledger-live-common/src/hooks/useMemoOnce.ts
...bs/ledger-live-common/src/families/cosmos/logic.ts
...r-live-common/src/families/filecoin/transaction.ts
...s/ledger-live-common/src/postOnboarding/reducer.ts
libs/ledger-live-common/src/generated/account.ts
...edger-live-common/src/transaction/signOperation.ts
libs/ledger-live-common/src/hw/isDevFirmware.ts
... and 604 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

@pierrelouis-c

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ofreyssinet-ledger ofreyssinet-ledger merged commit 1617b46 into develop Nov 8, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the feat/add-otg-banner-device-selection branch November 8, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants