Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one switch to enable multiple flags at once #1803

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Nov 14, 2022

📝 Description

See more info in FAT-649

  • Includes a fix for a crash that was happening in the "install set of apps" step of the sync onboarding: because of a bad conditional logic some text was getting rendered outside of a Text component.

❓ Context

  • Impacted projects: ledger-live-mobile ledger-live-desktop
  • Linked resource(s): FAT-649

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 2:21PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 16, 2022 at 2:21PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 16, 2022 at 2:21PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 16, 2022 at 2:21PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: f6edc55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
ledger-live-desktop Patch
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

overrideFeature(featureId, { ...getFeature(featureId), enabled: true }),
);
window.alert(
"You now have the one ring. Remember, with great power comes great responsibility.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@github-actions
Copy link

github-actions bot commented Nov 14, 2022

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 0.00% // Head: 87.77% // Increases project coverage by +87.77% 🎉

Coverage data is based on head (f6edc55) compared to base (f54ee9d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1803       +/-   ##
============================================
+ Coverage         0   87.77%   +87.77%     
============================================
  Files            0       16       +16     
  Lines            0     1309     +1309     
  Branches         0      252      +252     
============================================
+ Hits             0     1149     +1149     
- Misses           0      156      +156     
- Partials         0        4        +4     
Flag Coverage Δ
test 87.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/hw-app-eth/src/services/ledger/loadConfig.ts 100.00% <0.00%> (ø)
...s/packages/hw-app-eth/tests/fixtures/dynamicCAL.ts 100.00% <0.00%> (ø)
...ages/hw-app-eth/src/modules/EIP712/EIP712.utils.ts 93.93% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts 79.04% <0.00%> (ø)
...js/packages/hw-app-eth/src/modules/EIP712/index.ts 99.42% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-trx/src/utils.ts 61.40% <0.00%> (ø)
...s/packages/hw-app-eth/src/services/ledger/index.ts 98.57% <0.00%> (ø)
...ledgerjs/packages/hw-app-eth/tests/fixtures/CAL.ts 100.00% <0.00%> (ø)
...ckages/hw-app-eth/src/services/ledger/contracts.ts 95.65% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-trx/src/Trx.ts 81.94% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants