Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/split changeset to fix release #1808

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

cgrellard-ledger
Copy link
Contributor

📝 Description

Bugfix/split changeset to fix release

❓ Context

  • Impacted projects: changesets
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 0:06AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 15, 2022 at 0:06AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 15, 2022 at 0:06AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 15, 2022 at 0:06AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: 5c9d371

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ledgerhq/react-ui Minor
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 63.15% // Head: 69.77% // Increases project coverage by +6.61% 🎉

Coverage data is based on head (6bbb0d6) compared to base (af64e45).
Patch has no changes to coverable lines.

❗ Current head 6bbb0d6 differs from pull request most recent head 5c9d371. Consider uploading reports for the commit 5c9d371 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1808      +/-   ##
===========================================
+ Coverage    63.15%   69.77%   +6.61%     
===========================================
  Files            1       16      +15     
  Lines           57      622     +565     
  Branches         7      111     +104     
===========================================
+ Hits            36      434     +398     
- Misses          18      170     +152     
- Partials         3       18      +15     
Flag Coverage Δ
test 69.77% <ø> (+6.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/errors/src/index.ts 76.66% <0.00%> (ø)
...dgerjs/packages/cryptoassets/data/polygon-erc20.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/src/tokens.ts 75.40% <0.00%> (ø)
...dgerjs/packages/cryptoassets/data/cardanoNative.js 100.00% <0.00%> (ø)
...s/ledgerjs/packages/cryptoassets/src/currencies.ts 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/esdt.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/bep20.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/trc10.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/asa.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/src/fiats.ts 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valpinkman valpinkman merged commit d962486 into release Nov 15, 2022
@valpinkman valpinkman deleted the bugfix/split-changeset-to-fix-release branch November 15, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants