Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: integrate cic provider #1817

Merged
merged 17 commits into from
Nov 22, 2022
Merged

Feat: integrate cic provider #1817

merged 17 commits into from
Nov 22, 2022

Conversation

sarneijim
Copy link
Contributor

@sarneijim sarneijim commented Nov 15, 2022

πŸ“ Description

Intergrate CIC provider

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screenshot 2022-11-16 at 09 29 18

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 21, 2022 at 3:45PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 21, 2022 at 3:45PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 21, 2022 at 3:45PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 21, 2022 at 3:45PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

πŸ¦‹ Changeset detected

Latest commit: 4cf57fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ledgerhq/live-common Minor
live-mobile Minor
ledger-live-desktop Minor
@ledgerhq/live-cli Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM labels Nov 15, 2022
@github-actions
Copy link

github-actions bot commented Nov 15, 2022

@sarneijim

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@sarneijim sarneijim changed the title Feat: integrate cic provider Feat: integrate cic provider NO MERGE UNTIL REMOVE EXTRA COMMIT Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 47.03% // Head: 47.01% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7b5d530) compared to base (159b3f8).
Patch coverage: 90.00% of modified lines in pull request are covered.

❗ Current head 7b5d530 differs from pull request most recent head 4cf57fc. Consider uploading reports for the commit 4cf57fc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1817      +/-   ##
===========================================
- Coverage    47.03%   47.01%   -0.02%     
===========================================
  Files          674      682       +8     
  Lines        29439    30042     +603     
  Branches      7893     7998     +105     
===========================================
+ Hits         13846    14124     +278     
- Misses       14397    14710     +313     
- Partials      1196     1208      +12     
Flag Coverage Ξ”
test 47.01% <90.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...er-live-common/src/featureFlags/defaultFeatures.ts 100.00% <ΓΈ> (ΓΈ)
...edger-live-common/src/exchange/swap/utils/index.ts 65.59% <87.50%> (+2.06%) ⬆️
libs/ledger-live-common/src/exchange/swap/index.ts 92.45% <100.00%> (+0.29%) ⬆️
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-xrp/src/Xrp.ts 89.09% <0.00%> (ΓΈ)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-tezos/src/Tezos.ts 11.34% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-str/src/utils.ts 91.37% <0.00%> (ΓΈ)
...ibs/ledgerjs/packages/hw-app-algorand/src/utils.ts 38.88% <0.00%> (ΓΈ)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the translations Translation files have been touched label Nov 17, 2022
@sarneijim sarneijim changed the title Feat: integrate cic provider NO MERGE UNTIL REMOVE EXTRA COMMIT Feat: integrate cic provider Nov 17, 2022
@sarneijim sarneijim marked this pull request as ready for review November 17, 2022 10:50
@sarneijim sarneijim requested a review from a team as a code owner November 17, 2022 10:50
Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sarneijim sarneijim merged commit 74a7eb8 into develop Nov 22, 2022
@sarneijim sarneijim deleted the feat/integrate-cic-provider branch November 22, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants