Support/android target sdk 32 #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9d81164 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ofreyssinet-ledger
changed the title
github-actions
bot
added
mobile
| @@ -46,6 +55,7 @@ | |||
| android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode" | |||
| android:windowSoftInputMode="adjustResize" | |||
| android:screenOrientation="portrait" | |||
| android:exported="true" | |||
There was a problem hiding this comment.
needed for Android API >=31
cgrellard-ledger
approved these changes
Nov 15, 2022
|
LGTM |
thomasrogerlux
approved these changes
Nov 15, 2022
alexandremgo
approved these changes
Nov 16, 2022
valpinkman
added a commit
that referenced
this pull request
Nov 17, 2022
Support/android target sdk 32
valpinkman
added a commit
that referenced
this pull request
Nov 18, 2022
Support/android target sdk 32
valpinkman
added a commit
that referenced
this pull request
Nov 21, 2022
Support/android target sdk 32
elbywan
pushed a commit
that referenced
this pull request
Nov 22, 2022
Support/android target sdk 32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The Play Store now requires us to target Android SDK level >= 31.
In order to do this, we need some changes in the Bluetooth permissions flow. Here they are (I actually bumped to 32)
I only tested on Android 12 as I don't have other devices but it is necessary to test this PR with Android 9, 10 and 11 to be fully covered.
❓ Context
ledger-live-mobile✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.