-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if no srcDelegation avoid crash #1842
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 32633f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 42.71% // Head: 42.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release #1842 +/- ##
===========================================
+ Coverage 42.71% 42.95% +0.24%
===========================================
Files 622 625 +3
Lines 25838 26114 +276
Branches 7121 7202 +81
===========================================
+ Hits 11036 11218 +182
+ Misses 14748 13747 -1001
- Partials 54 1149 +1095
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
@henrily-ledger Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
apps/ledger-live-mobile/src/families/cosmos/RedelegationFlow/01-SelectValidator.tsx
Show resolved
Hide resolved
Also the white screen at the end looks weird to me π most likely acceptable to remove the blocker, but maybe removing the back button as you suggested made more sense?... unless the issue also happens on other screens than the final confirmation one. |
π Description
Crash when going back to a already redelegate delegation.
β Context
live-mobile
β Checklist
πΈ Demo
Screen.Recording.2022-11-17.at.10.26.32.mov
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.