Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if no srcDelegation avoid crash #1842

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

henri-ly
Copy link
Contributor

@henri-ly henri-ly commented Nov 17, 2022

πŸ“ Description

Crash when going back to a already redelegate delegation.

❓ Context

  • Impacted projects: live-mobile
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen.Recording.2022-11-17.at.10.26.32.mov

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@henri-ly henri-ly requested a review from a team as a code owner November 17, 2022 09:30
@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 17, 2022 at 10:08AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 17, 2022 at 10:08AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 17, 2022 at 10:08AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 17, 2022 at 10:08AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

πŸ¦‹ Changeset detected

Latest commit: 32633f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 42.71% // Head: 42.95% // Increases project coverage by +0.24% πŸŽ‰

Coverage data is based on head (32633f7) compared to base (ea34c13).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1842      +/-   ##
===========================================
+ Coverage    42.71%   42.95%   +0.24%     
===========================================
  Files          622      625       +3     
  Lines        25838    26114     +276     
  Branches      7121     7202      +81     
===========================================
+ Hits         11036    11218     +182     
+ Misses       14748    13747    -1001     
- Partials        54     1149    +1095     
Flag Coverage Ξ”
test 42.95% <ΓΈ> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/apps/support.ts 54.54% <ΓΈ> (ΓΈ)
libs/ledger-live-common/src/env.ts 72.22% <0.00%> (ΓΈ)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ΓΈ)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ΓΈ)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ΓΈ)
... and 244 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Nov 17, 2022

@henrily-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ghost
Copy link

ghost commented Nov 17, 2022

Also the white screen at the end looks weird to me πŸ˜„ most likely acceptable to remove the blocker, but maybe removing the back button as you suggested made more sense?... unless the issue also happens on other screens than the final confirmation one.
QA to decide if acceptable as it is.

@cgrellard-ledger cgrellard-ledger merged commit e0d07c1 into release Nov 18, 2022
@cgrellard-ledger cgrellard-ledger deleted the bugfix/LIVE-4599-redelegate-crash branch November 18, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants