Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LIVE-4623 Fix crash on Android 12+ during FW Update #1867

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

Starting on Android 12+ a hard requirement was introduced to set a flag on PendingIntent that caused a crash when attempting a firmware update. Following the error logs, this PR introduces said flag for affected versions.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-4623

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

🚀 Expectations to reach

  • For both Android < 12 and Android 12+, make sure that the firmware update works correctly without the crash.

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 3:44PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 18, 2022 at 3:44PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 18, 2022 at 3:44PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 18, 2022 at 3:44PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022

🦋 Changeset detected

Latest commit: 9cb8da4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Nov 18, 2022
@juan-cortes juan-cortes changed the base branch from develop to release November 18, 2022 10:48
@juan-cortes juan-cortes requested a review from a team as a code owner November 18, 2022 10:48
@juan-cortes juan-cortes requested a review from a team November 18, 2022 10:48
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 47.74% // Head: 43.82% // Decreases project coverage by -3.91% ⚠️

Coverage data is based on head (3268603) compared to base (99d1ecb).
Patch coverage: 46.00% of modified lines in pull request are covered.

❗ Current head 3268603 differs from pull request most recent head 9cb8da4. Consider uploading reports for the commit 9cb8da4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1867      +/-   ##
===========================================
- Coverage    47.74%   43.82%   -3.92%     
===========================================
  Files          702      636      -66     
  Lines        30701    26320    -4381     
  Branches      8092     7216     -876     
===========================================
- Hits         14658    11536    -3122     
+ Misses       14839    14724     -115     
+ Partials      1204       60    -1144     
Flag Coverage Δ
test 43.82% <46.00%> (-3.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/apps/logic.ts 89.71% <0.00%> (+28.97%) ⬆️
libs/ledger-live-common/src/apps/support.ts 54.54% <ø> (ø)
...live-common/src/families/bitcoin/hw-signMessage.ts 33.33% <0.00%> (ø)
...ve-common/src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (ø)
...e-common/src/families/bitcoin/wallet-btc/wallet.ts 9.21% <0.00%> (ø)
...-live-common/src/families/bitcoin/hw-getAddress.ts 25.00% <23.80%> (-6.82%) ⬇️
...-common/src/families/bitcoin/js-synchronisation.ts 20.00% <25.00%> (-0.17%) ⬇️
...common/src/families/ethereum/prepareTransaction.ts 75.00% <75.00%> (-2.42%) ⬇️
libs/ledger-live-common/src/apps/polyfill.ts 89.47% <100.00%> (+8.22%) ⬆️
libs/ledger-live-common/src/env.ts 72.22% <0.00%> (ø)
... and 314 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alalmi-ledger
Copy link
Contributor

QA OK, this can be merged

Copy link
Contributor

@alexandremgo alexandremgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants