Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-2627 use max instand of send max #1910

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

henri-ly
Copy link
Contributor

πŸ“ Description

UseMax instead of send max for solana and cosmos flow

❓ Context

  • Impacted projects: live-desktop
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screenshot 2022-11-21 at 17 19 46

Screenshot 2022-11-21 at 17 22 26

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@henri-ly henri-ly requested a review from a team as a code owner November 21, 2022 16:33
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

πŸ¦‹ Changeset detected

Latest commit: 91ca6e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 23, 2022 at 10:21AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 23, 2022 at 10:21AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 23, 2022 at 10:21AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 23, 2022 at 10:21AM (UTC)

@github-actions
Copy link

github-actions bot commented Nov 21, 2022

@henrily-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 45.55% // Head: 45.55% // No change to project coverage πŸ‘

Coverage data is based on head (f22d46a) compared to base (f22d46a).
Patch has no changes to coverable lines.

❗ Current head f22d46a differs from pull request most recent head 91ca6e9. Consider uploading reports for the commit 91ca6e9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1910   +/-   ##
========================================
  Coverage    45.55%   45.55%           
========================================
  Files          653      653           
  Lines        27960    27960           
  Branches      7530     7530           
========================================
  Hits         12738    12738           
  Misses       14059    14059           
  Partials      1163     1163           
Flag Coverage Ξ”
test 45.55% <0.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

@henri-ly henri-ly merged commit 7d1458a into develop Nov 23, 2022
@henri-ly henri-ly deleted the feat/LIVE-2627-use-max-instead-of-send-max branch November 23, 2022 14:23
ghost pushed a commit that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants