Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable storyly LLD #1916

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Disable storyly LLD #1916

merged 3 commits into from
Nov 22, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Nov 22, 2022

📝 Description

Following this conversation it's clear that we don't want to remotely load and inject some javascript in LLD as it's a big security vulnerability.
Storyly isn't urgently needed for now on LLD so we can disable it until we come up with a better solution (also because there are other priorities right now I don't have time to find the better solution, but disabling this script injection is still a big priority before the pre-release).

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): FAT-671

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

🦋 Changeset detected

Latest commit: ddb1a16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 9:41AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 22, 2022 at 9:41AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 22, 2022 at 9:41AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 22, 2022 at 9:41AM (UTC)

Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 47.83% // Head: 76.85% // Increases project coverage by +29.01% 🎉

Coverage data is based on head (ddb1a16) compared to base (d10c727).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1916       +/-   ##
============================================
+ Coverage    47.83%   76.85%   +29.01%     
============================================
  Files          704       20      -684     
  Lines        30822      700    -30122     
  Branches      8129      109     -8020     
============================================
- Hits         14745      538    -14207     
+ Misses       14846      147    -14699     
+ Partials      1231       15     -1216     
Flag Coverage Δ
test 76.85% <ø> (+29.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/hw-transport-mocker/src/openTransportReplayer.ts 63.63% <0.00%> (ø)
...hw-transport-mocker/src/createTransportReplayer.ts 13.79% <0.00%> (ø)
libs/ledger-live-common/src/account/accountId.ts
...edger-live-common/src/exchange/swap/hooks/index.ts
libs/ledger-live-common/src/bridge/mockHelpers.ts
...dger-live-common/src/families/cosmos/api/Cosmos.ts
...bs/ledger-live-common/src/families/tezos/bakers.ts
...ger-live-common/src/families/evm/api/rpc.common.ts
...r-live-common/src/families/stellar/js-broadcast.ts
...ibs/ledger-live-common/src/bridge/react/context.ts
... and 676 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ofreyssinet-ledger ofreyssinet-ledger merged commit 59bbf85 into develop Nov 22, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/remove-storyly branch November 22, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants