-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable storyly LLD #1916
Disable storyly LLD #1916
Conversation
🦋 Changeset detectedLatest commit: ddb1a16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportBase: 47.83% // Head: 76.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1916 +/- ##
============================================
+ Coverage 47.83% 76.85% +29.01%
============================================
Files 704 20 -684
Lines 30822 700 -30122
Branches 8129 109 -8020
============================================
- Hits 14745 538 -14207
+ Misses 14846 147 -14699
+ Partials 1231 15 -1216
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
📝 Description
Following this conversation it's clear that we don't want to remotely load and inject some javascript in LLD as it's a big security vulnerability.
Storyly isn't urgently needed for now on LLD so we can disable it until we come up with a better solution (also because there are other priorities right now I don't have time to find the better solution, but disabling this script injection is still a big priority before the pre-release).
❓ Context
ledger-live-desktop
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.