Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous onboarding on Mobile #330

Merged
merged 59 commits into from
Oct 12, 2022

Conversation

alexandremgo
Copy link
Contributor

@alexandremgo alexandremgo commented Jun 13, 2022

πŸ“ Description

Add synchronous onboarding for devices supporting it to Ledger Live Mobile, for more info see related slack channels.

❓ Context

  • Impacted projects: ledger-live-mobile, ledger-live-common, types-live
  • Linked resource(s): FAT-82

βœ… Checklist

  • Test coverage: no UI testing on mobile, logic is already tested in live common
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

N/A, see slack channel

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 12, 2022 at 10:57AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 12, 2022 at 10:57AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 12, 2022 at 10:57AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 12, 2022 at 10:57AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2022

πŸ¦‹ Changeset detected

Latest commit: 82b71c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
live-mobile Minor
@ledgerhq/native-ui Minor
@ledgerhq/types-devices Patch
@ledgerhq/live-common Patch
ledger-live-desktop Patch
@ledgerhq/live-cli Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Jun 13, 2022

@alexandremgo

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from 2b086d1 to c784b36 Compare June 15, 2022 08:19
@github-actions github-actions bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Jun 15, 2022
@alexandremgo
Copy link
Contributor Author

Rebased on #346 to have the sync onboarding mechanism

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Base: 48.07% // Head: 43.57% // Decreases project coverage by -4.50% ⚠️

Coverage data is based on head (b74b135) compared to base (52ecc41).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b74b135 differs from pull request most recent head 82b71c8. Consider uploading reports for the commit 82b71c8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
- Coverage    48.07%   43.57%   -4.51%     
===========================================
  Files          688      610      -78     
  Lines        30275    25490    -4785     
  Branches      7916     6979     -937     
===========================================
- Hits         14556    11108    -3448     
+ Misses       14505    14332     -173     
+ Partials      1214       50    -1164     
Flag Coverage Ξ”
test 43.57% <100.00%> (-4.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...er-live-common/src/featureFlags/defaultFeatures.ts 100.00% <ΓΈ> (ΓΈ)
...edger-live-common/src/hw/extractOnboardingState.ts 95.00% <100.00%> (+0.12%) ⬆️
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ΓΈ)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ΓΈ)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ΓΈ)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ΓΈ)
... and 314 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from c784b36 to b4b6070 Compare June 15, 2022 10:27
@github-actions github-actions bot added the cli label Jun 15, 2022
@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from d775734 to 196f9ad Compare June 23, 2022 12:40
@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from 196f9ad to f376c15 Compare June 23, 2022 13:30
@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from f376c15 to e704e74 Compare June 28, 2022 07:51
@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from 8a11693 to fdba854 Compare July 7, 2022 22:21
@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from fdba854 to 7446aca Compare July 7, 2022 22:38
thomasrogerlux and others added 25 commits October 12, 2022 12:55
* refactor(mobile): center error message when pairing fails

* fix(mobile): cleanup all states at the end of the sync onboarding properly

* refactor(mobile): use real bluetooth lottie in scanning

* fix(mobile): satisfies the lint-lord

* fix(mobile): lint-lord was still angry

* fix(mobile): update wording on ble pairing fail

* refactor(mobile): polish back/close buttons in ble pairing flow
@alexandremgo alexandremgo merged commit f7a8df0 into develop Oct 12, 2022
@alexandremgo alexandremgo deleted the feat/FAT-82-LLM-new-onboarding-flow branch October 12, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants