-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronous onboarding on Mobile #330
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 82b71c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2b086d1
to
c784b36
Compare
Rebased on #346 to have the sync onboarding mechanism |
Codecov ReportBase: 48.07% // Head: 43.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #330 +/- ##
===========================================
- Coverage 48.07% 43.57% -4.51%
===========================================
Files 688 610 -78
Lines 30275 25490 -4785
Branches 7916 6979 -937
===========================================
- Hits 14556 11108 -3448
+ Misses 14505 14332 -173
+ Partials 1214 50 -1164
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
c784b36
to
b4b6070
Compare
d775734
to
196f9ad
Compare
196f9ad
to
f376c15
Compare
f376c15
to
e704e74
Compare
8a11693
to
fdba854
Compare
fdba854
to
7446aca
Compare
* refactor(mobile): center error message when pairing fails * fix(mobile): cleanup all states at the end of the sync onboarding properly * refactor(mobile): use real bluetooth lottie in scanning * fix(mobile): satisfies the lint-lord * fix(mobile): lint-lord was still angry * fix(mobile): update wording on ble pairing fail * refactor(mobile): polish back/close buttons in ble pairing flow
cc643b3
to
82b71c8
Compare
π Description
Add synchronous onboarding for devices supporting it to Ledger Live Mobile, for more info see related slack channels.
β Context
ledger-live-mobile
,ledger-live-common
,types-live
β Checklist
Test coverage: no UI testing on mobile, logic is already tested in live commonπΈ Demo
N/A, see slack channel
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.