Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix generate-bot-super-report tool #5347

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

gre
Copy link
Contributor

@gre gre commented Nov 7, 2023

📝 Description

the tool has been broken due to fetch() api changes between web and node.js around the stream APIs. We also take opportunity to filter the "name" of the artifact to reduce number of pagination we will need to do.

also fix some TypeScript.

de2a012#commitcomment-131909173

❓ Context

  • Impacted projects: tools
  • Linked resource(s): [na]

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@gre gre requested a review from a team November 7, 2023 11:22
Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: f8f3e8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 11:51am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 11:51am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 11:51am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 11:51am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 11:51am

@live-github-bot live-github-bot bot added the tools Has changes in tools label Nov 7, 2023
@gre gre force-pushed the support/fix-generate-bot-super-report branch from 1721bcd to 79d648e Compare November 7, 2023 11:29
@gre gre force-pushed the support/fix-generate-bot-super-report branch from 79d648e to f8f3e8e Compare November 7, 2023 11:49
@gre gre requested a review from a team November 7, 2023 13:43
@gre gre merged commit 01527ad into develop Nov 9, 2023
19 of 21 checks passed
@gre gre deleted the support/fix-generate-bot-super-report branch November 9, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants