Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/fix(LIVE-10851) #5893

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Bugfix/fix(LIVE-10851) #5893

merged 9 commits into from
Jan 15, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Jan 11, 2024 •
edited
Loading

📝 Description

Screen.Recording.2024-01-11.at.10.04.14.mov

❓ Context

- JIRA link:

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.

  • [ ] Impact of the changes:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested review from a team as code owners January 11, 2024 09:21
@vercel Vercel
Copy link

vercel bot commented Jan 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 10:28am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 10:28am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 10:28am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 10:28am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 10:28am

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Jan 11, 2024
kallen-ledger
kallen-ledger previously approved these changes Jan 12, 2024
View reviewed changes
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 12, 2024
@live-github-bot live-github-bot bot added the common Has changes in live-common label Jan 12, 2024
@CremaFR CremaFR merged commit b45bcfd into develop Jan 15, 2024
59 of 61 checks passed
@CremaFR CremaFR deleted the bugfix/tezosswap branch January 15, 2024 13:26
@CremaFR CremaFR mentioned this pull request Jan 17, 2024
Closed
8 tasks
@CremaFR CremaFR restored the bugfix/tezosswap branch May 23, 2024 11:43
@CremaFR CremaFR mentioned this pull request May 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpellizzari-ledger cpellizzari-ledger cpellizzari-ledger left review comments

@kallen-ledger kallen-ledger kallen-ledger approved these changes

Assignees

@CremaFR CremaFR

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CremaFR @cpellizzari-ledger @kallen-ledger