-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUPPORT] : Rework Market with ReactQuery in LLD #6340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
Has changes in LLD
common
Has changes in live-common
translations
Translation files have been touched
labels
Feb 29, 2024
mcayuelas-ledger
force-pushed
the
support/react-query-market
branch
from
March 5, 2024 10:39
99a70ec
to
581dbeb
Compare
mcayuelas-ledger
force-pushed
the
support/react-query-market
branch
from
March 5, 2024 15:42
0e25c5d
to
6d64ed2
Compare
mcayuelas-ledger
force-pushed
the
support/react-query-market
branch
from
March 6, 2024 16:10
e5d957c
to
9f50347
Compare
mcayuelas-ledger
force-pushed
the
support/react-query-market
branch
2 times, most recently
from
March 7, 2024 13:29
c84e738
to
c054d3f
Compare
Contributor
Author
mcayuelas-ledger
force-pushed
the
support/react-query-market
branch
2 times, most recently
from
March 12, 2024 09:59
bf85007
to
5a5d163
Compare
live-github-bot
bot
added
the
ledgerjs
Has changes in the ledgerjs open source libs
label
Mar 12, 2024
mcayuelas-ledger
changed the title
[SUPPORT] : Rework Market with ReactQuery. (WIP ⚠️)
[SUPPORT] : Rework Market with ReactQuery in LLD
Mar 12, 2024
Contributor
Author
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
mcayuelas-ledger
force-pushed
the
support/react-query-market
branch
from
April 5, 2024 09:52
bfefffd
to
da30d51
Compare
KVNLS
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common
Has changes in live-common
desktop
Has changes in LLD
ledgerjs
Has changes in the ledgerjs open source libs
mobile
Has changes in LLM
screenshots
Screenshots have been updated
translations
Translation files have been touched
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Rework of Market pages in LLD with removal of
MarketDataProvider
:Settings
store to newMarket
storeTanstackQueryDevTool
inDeveloper
Tab in SettingsWith Rework :
Coin Detail Screen
Market List
MarketCrumb ✅
3 new Hooks :
useMarket
=> MarketList related actions and datauseMarketCoin
=> MarketCoin related actions and datauseMarketActions
=> Actions on currency (Buy/swap/Stake) used by both pagesNew Architecture :
market
┣ MarketCoin
┃ ┣ components
┃ ┃ ┣ MarketCoinChart.tsx
┃ ┃ ┗ MarketInfo.tsx
┃ ┗ index.tsx
┣ MarketList
┃ ┣ components
┃ ┃ ┣ MarketItemChart.tsx
┃ ┃ ┣ MarketRowItem.tsx
┃ ┃ ┗ NoCryptoPlaceholder.tsx
┃ ┗ index.tsx
┣ assets
┃ ┗ ChartPlaceholder.tsx
┣ components
┃ ┣ CountervalueSelect.tsx
┃ ┣ DropDown.tsx
┃ ┣ SideDrawerFilter.tsx
┃ ┣ SortTableCell.tsx
┃ ┗ Table.tsx
┣ hooks
┃ ┣ useMarket.ts
┃ ┣ useMarketActions.ts
┃ ┗ useMarketCoin.ts
┗ index.tsx
Context & Explanations :
https://ledgerhq.atlassian.net/wiki/spaces/WXP/pages/4559208461/Market+Rework
This PR should fix also some bugs related to Market on both LLM and LLD
(Initiatives)
Demo on LLD (Quick Demo)
Screen.Recording.2024-03-06.at.16.56.23.mov
Screen.Recording.2024-03-07.at.11.33.08.mov
FF & refreshRate example
Screen.Recording.2024-03-12.at.16.11.04.mov
Search & starred coins
Screen.Recording.2024-03-12.at.15.18.47.mov
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.QA Done ✅
https://ledgerhq.atlassian.net/browse/B2CQA-2227
🧐 Checklist for the PR Reviewers