fix(lld): fix duplicated learn more link inside error banner #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiz Scan Summary
|
LucasWerey
force-pushed
the
fix/live-7383
branch
from
aa696aa
to
2b8ab19
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
mcayuelas-ledger
approved these changes
Mar 20, 2024
gre
approved these changes
Mar 21, 2024
|
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
cgrellard-ledger
approved these changes
Apr 15, 2024
…o fix/live-7383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix an error causing the duplication of
learn morelink when infra error occurs.The link in the title of the errorBanner has been removed so we only keep the link from the description.
In the future these errors will be more UX friendly so we will display the same description as on ledger status website. So we will be able to remove this learn more link.
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changesetwas attached.🧐 Checklist for the PR Reviewers