-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIVE-10526][LLM] Fix navigation to firmware update #6536
Merged
ofreyssinet-ledger
merged 11 commits into
develop
from
bugfix/LIVE-10526-fwupdate-footer
Apr 5, 2024
Merged
[LIVE-10526][LLM] Fix navigation to firmware update #6536
ofreyssinet-ledger
merged 11 commits into
develop
from
bugfix/LIVE-10526-fwupdate-footer
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
ofreyssinet-ledger
changed the title
LIVE-10526
[LIVE-10526][LLM] Fix navigation to firmware update
Mar 26, 2024
ofreyssinet-ledger
force-pushed
the
bugfix/LIVE-10526-fwupdate-footer
branch
2 times, most recently
from
April 2, 2024 08:17
0ab8bf1
to
b3ab4be
Compare
ofreyssinet-ledger
force-pushed
the
bugfix/LIVE-10526-fwupdate-footer
branch
from
April 4, 2024 14:28
b3ab4be
to
54f1b5d
Compare
mcayuelas-ledger
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Hub part
valpinkman
approved these changes
Apr 5, 2024
valpinkman
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
Issue: There is an issue sometimes when navigating to the (new) firmware update flow: the Tab Bar at the bottom of the screen doesn't hide properly.
Reason: This is because we have done something wrong with the navigation setup for the FirmwareUpdate and it was inside the
MainNavigator
which is the navigator that has the Tab Bar. We have done a hacky workaround to hide the TabBar when the Firmware update screen is displayed but it's not the proper way to do it.Solution: Moving the
FirmwareUpdate
screen out of theMainNavigator
, directly inBaseNavigator
, and also inSyncOnboardingNavigator
(for the "early security checks" flow of the onboarding).On top of that, I've done some refactoring of the navigator/screen names and directory names for the
My Ledger
section because it was very confusing. (Manager is now called My Ledger in the UI, and the naming for the two screens,Manager
andManagerMain
was just confusing and impossible to understand on the first try).The 2 screens of MyLedgerNavigator are now called:
MyLedgerChooseDevice
andMyLedgerDevice
, I hope it is now self explanatory.❓ Context
🧐 Checklist for the PR Reviewers