Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sunset implicitMigration #6585

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

gre
Copy link
Contributor

@gre gre commented Mar 29, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: very old accounts will have to be reimported

📝 Description

in context of #6534
and for tech debt simplification, we remove the mechanism involving implicitMigration that was used back in 2020 to automatically migrate from libcore accounts to js accounts. Some years have past and we can drop this mechanism, worse case scenario is that users coming back from 2020 will have to reimport their accounts.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre gre requested a review from a team as a code owner March 29, 2024 14:41
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 2:47pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Mar 29, 2024 2:47pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Mar 29, 2024 2:47pm
native-ui-storybook ⬜️ Ignored (Inspect) Mar 29, 2024 2:47pm
react-ui-storybook ⬜️ Ignored (Inspect) Mar 29, 2024 2:47pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Mar 29, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@azure/[email protected] None 0 6.51 kB azure-sdk
npm/@babel/[email protected] environment, filesystem, unsafe +24 9.74 MB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe +24 9.75 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +3 2.65 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +18 7.16 MB nicolo-ribaudo
npm/@babel/[email protected] None +2 28 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +17 7.07 MB nicolo-ribaudo
npm/@babel/[email protected] environment +87 15.2 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +12 5.05 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +9 5.03 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +11 5.04 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +20 7.16 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 173 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 282 kB nicolo-ribaudo
npm/@braze/[email protected] None 0 252 kB appboy
npm/@braze/[email protected] None 0 415 kB appboy
npm/@cardano-foundation/[email protected] None 0 633 kB jan.mazak
npm/@celo/[email protected] None +1 321 kB alecps
npm/@celo/[email protected] filesystem, network +2 3.17 MB alecps
npm/@celo/[email protected] None +1 700 kB alecps
npm/@celo/[email protected] None +1 252 kB alecps
npm/@celo/[email protected] None +2 287 kB alecps
npm/@changesets/[email protected] Transitive: environment, network +2 98 kB changesets-release-bot
npm/@changesets/[email protected] environment, filesystem, shell +16 1.12 MB changesets-release-bot
npm/@commitlint/[email protected] Transitive: environment, filesystem +15 279 kB escapedcat
npm/@commitlint/[email protected] None 0 9.6 kB escapedcat
npm/@commitlint/[email protected] Transitive: environment +7 155 kB escapedcat
npm/@cosmjs/[email protected] None +4 302 kB webmaster128
npm/@cosmjs/[email protected] None +3 213 kB webmaster128
npm/@cosmjs/[email protected] Transitive: network +11 2.98 MB webmaster128
npm/@craftamap/[email protected] filesystem 0 26.7 kB craftamap
npm/@crypto-org-chain/[email protected] Transitive: network +22 10.5 MB calvinaco
npm/@dfinity/[email protected] network 0 1.27 MB krpeacock
npm/@dfinity/[email protected] None 0 647 kB krpeacock
npm/@dfinity/[email protected] None 0 140 kB krpeacock
npm/@electron/[email protected] filesystem, shell 0 64.5 kB electron-cfa
npm/@elrondnetwork/[email protected] None 0 179 kB andreibancioiu
npm/@elrondnetwork/[email protected] None +1 629 kB lucian.mincu
npm/@emotion/[email protected] environment 0 17.1 kB emotion-release-bot
npm/@emotion/[email protected] environment +1 75.3 kB emotion-release-bot
npm/@ethersproject/[email protected] Transitive: network +19 1.86 MB ricmoo
npm/@ethersproject/[email protected] None +2 180 kB ricmoo
npm/@ethersproject/[email protected] None 0 452 kB ricmoo

🚮 Removed packages: npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@gre gre merged commit 5a0a1aa into develop Mar 29, 2024
60 checks passed
@gre gre deleted the support/sunset-implicitMigration branch March 29, 2024 16:12
Copy link

sentry-io bot commented Apr 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: currency with id "arbitrum_goerli" not found getCryptoCurrencyById(libs/ledgerjs/packages/cr... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants