feat(LIVE-11102): add rate expired error message #6592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
live-github-bot
bot
added
desktop
| @@ -98,7 +102,14 @@ const initSwap = (input: InitSwapInput): Observable<SwapRequestEvent> => { | |||
| }); | |||
|
|
|||
| if (unsubscribed || !res || !res.data) return; | |||
| } catch (e) { | |||
| } catch (e: any) { | |||
| if (e.status == 422) { | |||
There was a problem hiding this comment.
for now we only have this single error case associated to status code 422, but we might have others in the future.
I would rather test more specifically on the messageKey="WRONG_OR_EXPIRED_RATE_ID"
| @@ -104,6 +104,7 @@ export const SwapExchangeRateAmountTooLowOrTooHigh = createCustomErrorClass( | |||
| ); | |||
|
|
|||
| export const SwapGenericAPIError = createCustomErrorClass("SwapGenericAPIError"); | |||
| export const SwapRateExpieredError = createCustomErrorClass("SwapRateExpieredError"); | |||
There was a problem hiding this comment.
Expiered -> Expired
cpellizzari-ledger
previously approved these changes
Apr 4, 2024
|
Deployment failed with the following error: |
mcayuelas-ledger
approved these changes
Apr 5, 2024
cpellizzari-ledger
approved these changes
Apr 5, 2024
lvndry
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add error message for expired rate
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-11102
🧐 Checklist for the PR Reviewers