Upgrade to React Native 0.73.6 #6596

KVNLS · 2024-04-02T16:54:18Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

The goal of this PR is to update to React Native 73.x and remove custom resolvers we use to favor symlink support introduced in latest react native version

Most impacting libraries update:

React-native from 0.72.6 to 0.73.6
react-native-reanimated from 3.3.0 to 3.8.1
react-native-ble-plx from 2.0.3 to 3.1.2
react-native-webview from 11.26.1 to 13.8.4 CANCELLED

And many other dependencies...

I also removed two UI components and related libraries that we don't use anymore:

Native UI
- Removal of Chart component with victory-native library
React UI
- Removal of Chart component with chart.js & chartjs-adapter-moment & react-chartjs-2

I upgraded Metro to the latest version and fine-tuned it to allow working with symlinks on our monorepo. This allows us to remove metro-extra-config package and rely directly on Metro to resolve our dependencies.

I migrated Java files to Kotlin for Android

Requirements for local execution

brew upgrade
Upgrade to Java 17
Clean cocoapods (rm -rf ~/.cocoapods/)
bundle install in ledger-live-mobile folder
XCode 15.3
pnpm clean
pnpm store prune

❓ Context

JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/LIVE-10596, https://ledgerhq.atlassian.net/browse/LIVE-11866

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-02T16:54:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 0:52am
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 0:52am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 0:52am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 0:52am
web-tools	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 0:52am

socket-security · 2024-04-03T08:51:09Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@actions/[email protected]	environment, filesystem Transitive: network, shell, unsafe	`+41`	16.1 MB	thboop
npm/@aws-sdk/[email protected]	Transitive: environment, filesystem, network, shell	`+94`	7.72 MB	aws-sdk-bot
npm/@babel/[email protected]	environment, filesystem, unsafe Transitive: shell	`+44`	10.1 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+10`	3.39 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+24`	4.69 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment, filesystem Transitive: shell	`+103`	10.1 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+10`	2.61 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	262 kB	nicolo-ribaudo
npm/@braze/[email protected]	None	`0`	278 kB	appboy
npm/@braze/[email protected]	None	`0`	454 kB	vismayasp
npm/@celo/[email protected]	Transitive: environment, eval, filesystem, network	`+97`	7.68 MB	alecps
npm/@celo/[email protected]	filesystem, network Transitive: environment, eval, shell, unsafe	`+276`	34.8 MB	alecps
npm/@celo/[email protected]	Transitive: environment, eval, filesystem, network	`+86`	13.9 MB	alecps
npm/@celo/[email protected]	Transitive: environment, filesystem, network	`+58`	4.22 MB	alecps
npm/@celo/[email protected]	Transitive: environment, filesystem, network	`+63`	4.87 MB	alecps
npm/@changesets/[email protected]	environment, filesystem, shell Transitive: eval, unsafe	`+243`	24.1 MB	changesets-release-bot
npm/@commitlint/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	`+161`	9.62 MB	escapedcat
npm/@commitlint/[email protected]	Transitive: filesystem	`+5`	44.9 kB	escapedcat
npm/@commitlint/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	`+106`	14 MB	escapedcat
npm/@cosmjs/[email protected]	None	`+5`	275 kB	webmaster128
npm/@cosmjs/[email protected]	Transitive: filesystem	`+15`	2.45 MB	webmaster128
npm/@cosmjs/[email protected]	Transitive: environment, eval, filesystem, network	`+48`	37.4 MB	webmaster128
npm/@dfinity/[email protected]	None	`+1`	178 kB	krpeacock
npm/@expo/[email protected]	environment, filesystem Transitive: eval, network, shell, unsafe	`+265`	27.1 MB	bycedric
npm/@formatjs/[email protected]	None	`+4`	2.94 MB	longlho
npm/@formatjs/[email protected]	None	`+2`	1.3 MB	longlho
npm/@formatjs/[email protected]	None	`+2`	5.3 MB	longlho
npm/@helium/[email protected]	None	`+4`	621 kB	peroni-nova
npm/@helium/[email protected]	Transitive: environment	`+5`	250 kB	peroni-nova
npm/@ledgerhq/[email protected]	None	`+1`	251 kB	achabrolin-ledger
npm/@playwright/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+2`	10.1 MB	dgozman-ms
npm/@playwright/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+2`	10.1 MB	yurys
npm/@react-native-async-storage/[email protected]	None	`+2`	445 kB	krizzu
npm/@react-native-clipboard/[email protected]	None	`0`	211 kB	naturalclar
npm/@react-native-community/[email protected]	environment, filesystem, shell Transitive: network	`+80`	3.07 MB	thymikee
npm/@react-native-community/[email protected]	environment, filesystem, shell Transitive: network	`+47`	1.7 MB	thymikee
npm/@react-native-community/[email protected]	environment, filesystem, shell Transitive: eval, network, unsafe	`+70`	2.08 MB	thymikee
npm/@react-native-community/[email protected]	environment, filesystem, shell Transitive: eval, network, unsafe	`+138`	6.78 MB	thymikee
npm/@react-native-community/[email protected]	network	`0`	511 kB	mattoakes
npm/@react-native-community/[email protected]	None	`0`	254 kB	bartoszklonowski
npm/@react-native-firebase/[email protected]	Transitive: environment, filesystem, shell, unsafe	`+64`	4.76 MB	salakar
npm/@react-native-firebase/[email protected]	None	`0`	211 kB	salakar
npm/@react-native-firebase/[email protected]	None	`0`	109 kB	salakar
npm/@react-native-masked-view/[email protected]	None	`0`	58.2 kB	naturalclar
npm/@react-native/[email protected]	environment Transitive: filesystem, shell, unsafe	`+103`	15.2 MB	react-native-bot
npm/@react-native/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+34`	13.2 MB	react-native-bot
npm/@react-native/[email protected]	None	`0`	168 kB	react-native-bot
npm/@react-native/[email protected]	environment Transitive: eval, filesystem, network, unsafe	`+43`	2.77 MB	react-native-bot
npm/@react-navigation/[email protected]	None	`+1`	222 kB	satya164
npm/@react-navigation/[email protected]	environment	`+8`	1.12 MB	satya164
npm/@react-navigation/[email protected]	environment, eval, network	`+47`	1.23 MB	satya164
npm/@react-navigation/[email protected]	environment	`0`	234 kB	satya164
npm/@react-navigation/[email protected]	None	`+1`	92.4 kB	satya164
npm/@react-navigation/[email protected]	environment	`+1`	324 kB	satya164
npm/@react-navigation/[email protected]	None	`+1`	668 kB	satya164
npm/@segment/[email protected]	network Transitive: environment, filesystem	`+110`	5.27 MB	oscb
npm/@sentry/[email protected]	environment, filesystem, network, shell	`+8`	402 kB	sentry-bot
npm/@sentry/[email protected]	filesystem, network, shell	`+8`	11.1 MB	sentry-bot
npm/@sentry/[email protected]	environment, filesystem, network, shell, unsafe	`+3`	6.65 MB	sentry-bot
npm/@sentry/[email protected]	Transitive: environment, eval, filesystem, network, shell	`+25`	13 MB	sentry-bot
npm/@sentry/[email protected]	Transitive: network	`+3`	4.63 MB	sentry-bot
npm/@sentry/[email protected]	None	`0`	312 kB	sentry-bot
npm/@storybook/[email protected]	environment, eval	`+5`	3.28 MB	shilman
npm/@storybook/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+502`	66.7 MB	shilman
npm/@storybook/[email protected]	environment, eval	`+4`	611 kB	shilman
npm/@storybook/[email protected]	eval Transitive: environment, filesystem, network	`+155`	32.2 MB	shilman
npm/@storybook/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+103`	15.8 MB	shilman
npm/@storybook/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+642`	73.5 MB	shilman
npm/@storybook/[email protected]	Transitive: environment, eval, filesystem, network	`+45`	9.74 MB	shilman
npm/@stricahq/[email protected]	None	`+4`	530 kB	ashisherc
npm/@swc/[email protected]	environment, filesystem, shell	`+2`	397 kB	kdy1
npm/@swc/[email protected]	filesystem Transitive: environment	`+11`	802 kB	kdy1
npm/@tanstack/[email protected]	environment	`+1`	3.58 MB	tannerlinsley
npm/@tanstack/[email protected]	environment	`+1`	3.79 MB	tannerlinsley
npm/@testing-library/[email protected]	environment Transitive: eval	`+61`	4.94 MB	testing-library-bot
npm/@testing-library/[email protected]	None	`+28`	1.81 MB	testing-library-bot
npm/@testing-library/[email protected]	environment	`+11`	1.37 MB	mdjastrzebski
npm/@testing-library/[email protected]	environment	`+2`	5.49 MB	testing-library-bot
npm/@testing-library/[email protected]	None	`0`	435 kB	testing-library-bot
npm/@types/[email protected]	None	`+1`	12.5 kB	types
npm/@types/[email protected]	None	`0`	3.09 kB	types
npm/@types/[email protected]	None	`+2`	31.7 kB	types
npm/@types/[email protected]	None	`0`	5.87 kB	types
npm/@types/[email protected]	None	`0`	60.4 kB	types
npm/@types/[email protected]	None	`+1`	164 kB	types
npm/@types/[email protected]	None	`+1`	145 kB	types
npm/@types/[email protected]	None	`0`	6.45 kB	types
npm/@types/[email protected]	Transitive: eval	`+6`	318 kB	types
npm/@types/[email protected]	None	`0`	862 kB	types
npm/@types/[email protected]	None	`0`	5.17 kB	types
npm/@types/[email protected]	None	`0`	1.96 MB	types
npm/@types/[email protected]	None	`0`	6.93 kB	types
npm/@types/[email protected]	None	`0`	7.8 kB	types
npm/@types/[email protected]	None	`0`	6.71 kB	types
npm/@types/[email protected]	None	`0`	18.4 kB	types
npm/@types/[email protected]	None	`0`	7.29 kB	types
npm/@types/[email protected]	None	`0`	8.16 kB	types
npm/@types/[email protected]	None	`0`	6.23 kB	types
npm/@types/[email protected]	None	`0`	6.39 kB	types
npm/@types/[email protected]	None	`0`	5.76 kB	types
npm/@types/[email protected]	None	`0`	3.77 kB	types
npm/@types/[email protected]	None	`+1`	401 kB	types
npm/@types/[email protected]	None	`0`	10.6 kB	types
npm/@types/[email protected]	None	`0`	34.3 kB	types
npm/@types/[email protected]	None	`0`	33.3 kB	types
npm/@types/[email protected]	None	`0`	8.14 kB	types
npm/@types/[email protected]	None	`0`	18.5 kB	types
npm/@types/[email protected]	None	`0`	4.97 kB	types
npm/@types/[email protected]	None	`0`	4.55 kB	types
npm/@types/[email protected]	None	`0`	25.8 kB	types
npm/@types/[email protected]	None	`0`	431 kB	types
npm/@types/[email protected]	None	`0`	11 kB	types
npm/@types/[email protected]	None	`0`	8.05 kB	types
npm/@types/[email protected]	None	`0`	23.3 kB	types
npm/@types/[email protected]	None	`0`	10.6 kB	types
npm/@types/[email protected]	None	`+1`	22.9 kB	types
npm/@types/[email protected]	None	`+1`	397 kB	types
npm/@types/[email protected]	None	`0`	23.2 kB	types
npm/@types/[email protected]	None	`0`	64.6 kB	types
npm/@types/[email protected]	None	`0`	35.4 kB	types
npm/@types/[email protected]	None	`0`	5.58 kB	types
npm/@types/[email protected]	None	`0`	6.74 kB	types
npm/@types/[email protected]	None	`0`	8.24 kB	types
npm/@types/[email protected]	None	`0`	8.92 kB	types
npm/@types/[email protected]	None	`0`	4.96 kB	types
npm/@types/[email protected]	None	`0`	21.7 kB	types
npm/@typescript-eslint/[email protected]	Transitive: environment, filesystem	`+38`	6.55 MB	jameshenry
npm/@zondax/[email protected]	None	`+1`	507 kB	jleni
npm/@zondax/[email protected]	Transitive: network	`+12`	7.48 MB	jleni
npm/[email protected]	None	`0`	808 kB	aearly
npm/[email protected]	None	`0`	17.2 kB	necolas
npm/[email protected]	environment, filesystem Transitive: shell	`+75`	9.66 MB	wschurman
npm/[email protected]	None	`0`	175 kB	peterolson
npm/[email protected]	None	`+1`	1.1 MB	junderw
npm/[email protected]	filesystem Transitive: network	`+37`	10.4 MB	casper-sre
npm/[email protected]	environment, filesystem Transitive: shell	`+3`	179 kB	gustavohenke
npm/[email protected]	Transitive: environment, eval, filesystem, unsafe	`+25`	3.14 MB	sindresorhus
npm/[email protected]	environment, filesystem, shell Transitive: network	`+39`	2.15 MB	electron-nightly
npm/[email protected]	environment, filesystem, network, shell	`0`	133 kB	evanw
npm/[email protected]	None	`0`	20.8 kB	lydell
npm/[email protected]	filesystem	`+35`	2.87 MB	simenb
npm/[email protected]	Transitive: eval	`+93`	9.51 MB	ljharb
npm/[email protected]	Transitive: environment	`+4`	159 kB	jounqin
npm/[email protected]	None	`0`	13.6 kB	arnaud-barre
npm/[email protected]	filesystem Transitive: environment, eval	`+96`	5.78 MB	ljharb
npm/[email protected]	environment, filesystem Transitive: eval, shell, unsafe	`+76`	10.5 MB	eslintbot
npm/[email protected]	None	`0`	145 kB	brentvatne
npm/[email protected]	None	`0`	785 kB	brentvatne
npm/[email protected]	Transitive: environment, filesystem, network, shell, unsafe	`+102`	9.57 MB	brentvatne
npm/[email protected]	None	`0`	350 kB	brentvatne
npm/[email protected]	None	`+1`	177 kB	brentvatne
npm/[email protected]	None	`0`	18.6 kB	wschurman
npm/[email protected]	None	`0`	127 kB	brentvatne
npm/[email protected]	None	`0`	51.5 kB	brentvatne
npm/[email protected]	environment, filesystem, unsafe Transitive: network, shell	`+101`	7.54 MB	brentvatne
npm/[email protected]	None	`0`	1.52 MB	brentvatne
npm/[email protected]	environment, network Transitive: eval, filesystem, shell, unsafe	`+443`	43 MB	brentvatne
npm/[email protected]	environment Transitive: eval, filesystem, network, shell, unsafe	`+444`	45.6 MB	kudochien
npm/[email protected]	None	`+1`	1.29 MB	ndubien
npm/[email protected]	Transitive: environment, filesystem, network	`+80`	114 MB	google-wombot
npm/[email protected]	Transitive: filesystem, unsafe	`+5`	1.4 MB	flowtype
npm/[email protected]	None	`+1`	768 kB	stefcameron
npm/[email protected]	environment, filesystem, network Transitive: shell	`+22`	1.85 MB	thornjad
npm/[email protected]	None	`0`	634 kB	adrai
npm/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+94`	9.96 MB	simenb
npm/[email protected]	None	`0`	430 kB	daishi
npm/[email protected]	None	`0`	119 kB	dcode
npm/[email protected]	None	`0`	286 kB	matinzd
npm/[email protected]	None	`0`	134 kB	isaacs
npm/[email protected]	None	`+1`	37.4 kB	metro-bot
npm/[email protected]	None	`0`	88.1 kB	metro-bot
npm/[email protected]	None	`0`	73.3 kB	metro-bot
npm/[email protected]	Transitive: environment, filesystem	`+33`	5.66 MB	metro-bot
npm/[email protected]	Transitive: environment, eval, filesystem, network	`+37`	9.99 MB	metro-bot
npm/[email protected]	environment, filesystem, network Transitive: shell, unsafe	`+92`	9.86 MB	metro-bot
npm/[email protected]	None	`0`	4.35 MB	ichernev
npm/[email protected]	environment, filesystem, shell	`+37`	5.91 MB	kettanaito
npm/[email protected]	environment, filesystem, shell	`+37`	5.91 MB	kettanaito
npm/[email protected]	environment, filesystem, network	`+1`	198 kB	nockbot
npm/[email protected]	Transitive: environment, filesystem	`+3`	2.36 MB	todbot
npm/[email protected]	None	`0`	1.64 MB	vitaly
npm/[email protected]	environment, filesystem Transitive: network, shell	`+27`	613 kB	lovell
npm/[email protected]	environment, filesystem, unsafe	`0`	8.39 MB	prettier-bot
npm/[email protected]	filesystem Transitive: environment	`+26`	1.69 MB	soldair
npm/[email protected]	Transitive: eval	`+10`	514 kB	ljharb
npm/[email protected]	None	`+1`	496 kB	valentinhervieu
npm/[email protected]	None	`+2`	390 kB	adrai
npm/[email protected]	Transitive: environment, eval, filesystem, network	`+4`	28 MB	qchen
npm/[email protected]	None	`0`	1.22 MB	uerceg
npm/[email protected]	None	`0`	59.8 kB	oblador
npm/[email protected]	Transitive: environment, filesystem, shell, unsafe	`+118`	10.8 MB	dominik-czupryna-withintent
npm/[email protected]	Transitive: environment, eval, filesystem, network, shell	`+53`	2.06 MB	ijzerenhein
npm/[email protected]	None	`0`	129 kB	luancurti
npm/[email protected]	environment, filesystem, network, shell	`+17`	220 kB	jhen0409
npm/[email protected]	None	`0`	104 kB	dylanvann
npm/[email protected]	None	`0`	120 kB	flipper-bot
npm/[email protected]	None	`+2`	4.21 MB	jakub.piasecki
npm/[email protected]	None	`+2`	24.9 kB	linusu
npm/[email protected]	None	`0`	696 kB	mkuczera
npm/[email protected]	None	`0`	174 kB	johandutoit
npm/[email protected]	None	`0`	26.7 kB	iamolegga
npm/[email protected]	None	`0`	171 kB	zoontek
npm/[email protected]	None	`0`	72 kB	thebylito
npm/[email protected]	None	`0`	184 kB	trozee
npm/[email protected]	environment, eval	`+9`	6.21 MB	piaskowyk
npm/[email protected]	environment	`0`	236 kB	janicduplessis
npm/[email protected]	None	`+2`	1.29 MB	tboba
npm/[email protected]	None	`0`	313 kB	mateusandrade
npm/[email protected]	None	`0`	23 kB	doomsower
npm/[email protected]	network	`+24`	9.62 MB	wolewicki
npm/[email protected]	None	`+1`	290 kB	kacperkapusciak
npm/[email protected]	None	`+1`	176 kB	tradle-react-native-udp
npm/[email protected]	Transitive: environment, filesystem	`+14`	7.94 MB	oblador
npm/[email protected]	None	`+5`	24.9 MB	olivier.bouillet
npm/[email protected]	environment Transitive: eval, network	`+18`	4.25 MB	necolas
npm/[email protected]	environment, network Transitive: eval, filesystem, shell, unsafe	`+843`	332 MB	react-native-bot
npm/[email protected]	None	`0`	74.3 kB	korangar
npm/[email protected]	environment	`+6`	810 kB	mjackson
npm/[email protected]	environment	`+9`	949 kB	mjackson
npm/[email protected]	environment	`+2`	376 kB	eps1lon
npm/[email protected]	environment	`0`	28.8 kB	brianvaughn
npm/[email protected]	environment	`+1`	918 kB	brianvaughn
npm/[email protected]	None	`+2`	682 kB	plwai
npm/[email protected]	None	`0`	32.1 kB	acemarke
npm/[email protected]	environment	`0`	176 kB	acemarke
npm/[email protected]	environment, filesystem	`+13`	412 kB	vercel-release-bot
npm/[email protected]	Transitive: environment, eval, filesystem, network, shell	`+27`	2.49 MB	probotbot
npm/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+358`	61.6 MB	shilman
npm/[email protected]	eval, network	`+22`	18.1 MB	storyly
npm/[email protected]	environment Transitive: filesystem	`+145`	28.4 MB	probablyup
npm/[email protected]	environment Transitive: filesystem	`+8`	3.44 MB	probablyup
npm/[email protected]	environment, filesystem Transitive: eval, unsafe	`+146`	6.21 MB	ybiquitous
npm/[email protected]	None	`0`	10.2 kB	dabh
npm/[email protected]	environment, eval, filesystem Transitive: network, shell, unsafe	`+99`	7.62 MB	egoist
npm/[email protected]	None	`0`	32.4 MB	typescript-bot
npm/[email protected]	None	`0`	64.3 kB	piotrwitek
npm/[email protected]	environment, eval, network Transitive: filesystem, shell, unsafe	`+256`	16.9 MB	evilebottnawi
npm/[email protected]	environment, filesystem, network, unsafe Transitive: eval, shell	`+197`	33.9 MB	evilebottnawi
npm/[email protected]	Transitive: environment	`+7`	532 kB	dabh
npm/[email protected]	filesystem, network Transitive: environment	`+22`	927 kB	dabh
npm/[email protected]	filesystem	`+1`	89.1 kB	npm-cli-ops
npm/[email protected]	environment, network	`0`	141 kB	lpinca
npm/[email protected]	None	`0`	794 kB	xstate-release-bot
npm/[email protected]	environment, filesystem Transitive: network, shell	`+53`	11.1 MB	google-wombot

View full report↗︎

socket-security · 2024-04-03T10:12:53Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

live-github-bot · 2024-04-03T10:35:15Z

Desktop Bundle Checks

Comparing 623366c against 6db18ce.

⚠️ main bundle size significantly increased: 1.3mb -> 1.6mb. Please check if this is expected.
⚠️ renderer bundle size significantly increased: 37.7mb -> 38.2mb. Please check if this is expected.
⚠️ ajv library is now duplicated in main (regression)
⚠️ safe-buffer library is now duplicated in renderer (regression)
⚠️ readable-stream library is now duplicated in renderer (regression)
⚠️ elliptic library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/classCallCheck library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/createClass library is now duplicated in renderer (regression)
⚠️ @noble/hashes/blake2b library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/inherits library is now duplicated in renderer (regression)
⚠️ fp-ts/lib/Either library is now duplicated in renderer (regression)
⚠️ io-ts library is now duplicated in renderer (regression)
⚠️ isarray library is now duplicated in renderer (regression)
⚠️ @emotion/weak-memoize library is now duplicated in renderer (regression)
⚠️ @emotion/hash library is now duplicated in renderer (regression)
⚠️ @emotion/unitless library is now duplicated in renderer (regression)
⚠️ @floating-ui/core library is now duplicated in renderer (regression)
⚠️ @floating-ui/dom library is now duplicated in renderer (regression)
⚠️ memoize-one library is now duplicated in renderer (regression)
⚠️ idb library is now duplicated in renderer (regression)
🚀 semver library is no longer duplicated in main
🚀 tslib library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/extends library is no longer duplicated in renderer
🚀 @ethersproject/rlp library is no longer duplicated in renderer
🚀 @ethersproject/address library is no longer duplicated in renderer
🚀 @ethersproject/constants library is no longer duplicated in renderer
🚀 @ethersproject/hash library is no longer duplicated in renderer
🚀 isomorphic-ws library is no longer duplicated in renderer
🚀 @noble/curves/secp256k1 library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/extends library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/objectWithoutPropertiesLoose library is no longer duplicated in renderer
🚀 chart.js library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/taggedTemplateLiteral library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/objectWithoutProperties library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/slicedToArray library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/typeof library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/classCallCheck library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/createClass library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/inherits library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/defineProperty library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/toConsumableArray library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/objectWithoutProperties library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/taggedTemplateLiteral library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/inheritsLoose library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/assertThisInitialized library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing 623366c against 879fda4.

🚀 main.ios.jsbundle bundle size decreased (59.6mb -> 58.7mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (59.6mb -> 58.7mb). Thanks ❤️

valpinkman · 2024-04-03T13:01:13Z

apps/ledger-live-mobile/android/app/build.gradle

-        exclude group:'com.squareup.okhttp3', module:'okhttp'
-    }
-   debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}")
+    implementation("com.facebook.react:flipper-integration")


valpinkman · 2024-04-03T13:16:42Z

libs/coin-modules/coin-bitcoin/src/wallet-btc/__tests__/xpub.txs.P2WPKH.integration.test.ts

@@ -105,6 +105,8 @@ describe.skip("testing xpub native segwit transactions", () => {
        .toString("hex");

      psbt.addInput({
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+        //@ts-expect-error


better to add a comment here after the expect-error, we can use this rule

Thanks, I will update it

* feat: Upgrade dependencies * fix: iOS build * fix: Android build and migrate to Kotlin * feat: use Metro Symlink resolver and cleanup our custom resolver * fix: Update Tooling and CI * chore: cleanup unused components and libs * fix: linter * fix: test on our mac runners * fix: types for react-native-webview * fix: revert react-native-webview version * fix: run ios cli * fix: increase memory for test libraries job

KVNLS self-assigned this Apr 2, 2024

live-github-bot bot added mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools labels Apr 2, 2024

vercel bot deployed to Preview – web-tools April 2, 2024 17:00 View deployment

KVNLS force-pushed the feat/update-react-native-73 branch from 5c490c4 to 2be1eba Compare April 3, 2024 08:49

vercel bot deployed to Preview – react-ui-storybook April 3, 2024 08:52 View deployment

vercel bot deployed to Preview – native-ui-storybook April 3, 2024 08:56 View deployment

vercel bot deployed to Preview – web-tools April 3, 2024 08:56 View deployment

KVNLS force-pushed the feat/update-react-native-73 branch from 2be1eba to 51a469d Compare April 3, 2024 10:11

live-github-bot bot added desktop Has changes in LLD cli labels Apr 3, 2024

vercel bot deployed to Preview – react-ui-storybook April 3, 2024 10:14 View deployment

vercel bot deployed to Preview – web-tools April 3, 2024 10:18 View deployment

valpinkman reviewed Apr 3, 2024

View reviewed changes

vercel bot deployed to Preview – native-ui-storybook April 4, 2024 13:59 View deployment

vercel bot deployed to Preview – react-ui-storybook April 4, 2024 14:01 View deployment

vercel bot deployed to Preview – web-tools April 4, 2024 14:03 View deployment

KVNLS force-pushed the feat/update-react-native-73 branch 2 times, most recently from e65bf69 to bbcc9bc Compare April 5, 2024 08:29

vercel bot deployed to Preview – web-tools April 5, 2024 08:37 View deployment

KVNLS force-pushed the feat/update-react-native-73 branch from bbcc9bc to 1cf0175 Compare April 5, 2024 15:22

vercel bot deployed to Preview – web-tools April 5, 2024 15:30 View deployment

KVNLS force-pushed the feat/update-react-native-73 branch from a26c1ec to 9f45b73 Compare May 20, 2024 07:54

KVNLS dismissed Justkant’s stale review via 7aab985 May 20, 2024 08:38

Justkant previously approved these changes May 20, 2024

View reviewed changes

KVNLS dismissed Justkant’s stale review via 27f68f8 May 20, 2024 10:40

KVNLS force-pushed the feat/update-react-native-73 branch 2 times, most recently from 27f68f8 to 60774a4 Compare May 20, 2024 10:47

KVNLS requested review from Justkant, lvndry, cpellizzari-ledger, ofreyssinet-ledger and valber-ledger May 20, 2024 11:22

lvndry previously approved these changes May 20, 2024

View reviewed changes

KVNLS added 11 commits May 20, 2024 14:12

feat: Upgrade dependencies

360a5a3

fix: iOS build

3595efb

fix: Android build and migrate to Kotlin

a30ff71

feat: use Metro Symlink resolver and cleanup our custom resolver

8a1e59f

fix: Update Tooling and CI

d460ed4

chore: cleanup unused components and libs

5b533e8

fix: linter

9b615a8

fix: test on our mac runners

80c24a0

fix: types for react-native-webview

9a630e4

fix: revert react-native-webview version

76d5acd

fix: run ios cli

1e9ea26

KVNLS dismissed lvndry’s stale review via 5e69111 May 20, 2024 12:13

KVNLS force-pushed the feat/update-react-native-73 branch from 60774a4 to 5e69111 Compare May 20, 2024 12:13

fix: increase memory for test libraries job

623366c

KVNLS force-pushed the feat/update-react-native-73 branch from 5e69111 to 623366c Compare May 20, 2024 12:51

KVNLS merged commit 77fa530 into develop May 20, 2024
51 of 54 checks passed

KVNLS deleted the feat/update-react-native-73 branch May 20, 2024 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to React Native 0.73.6 #6596

Upgrade to React Native 0.73.6 #6596

KVNLS commented Apr 2, 2024 •

edited

Loading

vercel bot commented Apr 2, 2024 •

edited

Loading

socket-security bot commented Apr 3, 2024 •

edited

Loading

socket-security bot commented Apr 3, 2024 •

edited

Loading

live-github-bot bot commented Apr 3, 2024 •

edited

Loading

valpinkman Apr 3, 2024

valpinkman Apr 3, 2024

KVNLS Apr 24, 2024

Upgrade to React Native 0.73.6 #6596

Upgrade to React Native 0.73.6 #6596

Conversation

KVNLS commented Apr 2, 2024 • edited Loading

✅ Checklist

📝 Description

Requirements for local execution

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 2, 2024 • edited Loading

socket-security bot commented Apr 3, 2024 • edited Loading

socket-security bot commented Apr 3, 2024 • edited Loading

live-github-bot bot commented Apr 3, 2024 • edited Loading

Desktop Bundle Checks

Mobile Bundle Checks

valpinkman Apr 3, 2024

Choose a reason for hiding this comment

valpinkman Apr 3, 2024

Choose a reason for hiding this comment

KVNLS Apr 24, 2024

Choose a reason for hiding this comment

KVNLS commented Apr 2, 2024 •

edited

Loading

vercel bot commented Apr 2, 2024 •

edited

Loading

socket-security bot commented Apr 3, 2024 •

edited

Loading

socket-security bot commented Apr 3, 2024 •

edited

Loading

live-github-bot bot commented Apr 3, 2024 •

edited

Loading