Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: do not close drawer after startExchange #6601

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Apr 3, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Stop closing drawer after start exchange as it is always followed by a completeExchange

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner April 3, 2024 09:26
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 9:31am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 9:31am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 9:31am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 9:31am
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 9:31am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 3, 2024
@CremaFR CremaFR merged commit 6066acb into develop Apr 8, 2024
37 of 40 checks passed
@CremaFR CremaFR deleted the bugfix/drawer-closes-between-steps branch April 8, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants