-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUPPORT]: Remove .unit usage from account.unit #6604
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
mcayuelas-ledger
force-pushed
the
support/move-unit
branch
from
April 4, 2024 08:18
a79adda
to
0816cab
Compare
mcayuelas-ledger
force-pushed
the
support/move-unit
branch
from
April 4, 2024 13:56
0816cab
to
b6e856f
Compare
gre
reviewed
Apr 4, 2024
apps/ledger-live-desktop/src/renderer/components/DeviceAction/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/Operation.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/drawers/DataSelector/AccountList.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/families/bitcoin/FullNode/steps/StepAccounts.tsx
Outdated
Show resolved
Hide resolved
mcayuelas-ledger
force-pushed
the
support/move-unit
branch
2 times, most recently
from
April 17, 2024 07:45
bc6d903
to
1bc9808
Compare
mcayuelas-ledger
force-pushed
the
support/move-unit
branch
from
April 25, 2024 12:44
1bc9808
to
3094e63
Compare
This reverts commit 39b4161.
This was referenced Apr 26, 2024
Closed
=> #6796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
Move "unit" field out of Account and move the related settings from Account settings back to the Currency settings (LLD only currently, LLM will be next)
Screen.Recording.2024-04-03.at.14.41.45.mov
❓ Context
🧐 Checklist for the PR Reviewers