Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix/LIVE-11850]: Add additional properties to the accepted & cancelled swap API calls. #6612

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

kallen-ledger
Copy link
Contributor

@kallen-ledger kallen-ledger commented Apr 4, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Add additional optional properties to the accepted & cancelled swap API calls.

For cancelled calls

statusCode: string;
errorMessage: string;
sourceCurrencyId: string;
targetCurrencyId: string;
hardwareWalletType: DeviceModelId;
swapType: TradeMethod;

and accepted calls

sourceCurrencyId: string;
targetCurrencyId: string;
hardwareWalletType: string;

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-11850


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@kallen-ledger kallen-ledger self-assigned this Apr 4, 2024
@kallen-ledger kallen-ledger requested a review from a team as a code owner April 4, 2024 13:53
Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 5, 2024 10:41am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 10:41am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 10:41am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 10:41am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 10:41am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Apr 4, 2024
sarneijim
sarneijim previously approved these changes Apr 4, 2024
@sarneijim sarneijim self-requested a review April 4, 2024 15:17
@@ -88,6 +100,7 @@ export default function ExchangeDrawer({ swapTransaction, exchangeRate, onComple
});
setError(error);
},
// eslint-disable-next-line react-hooks/exhaustive-deps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we ignoring those deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding these dependencies will cause further renders which will then cause an error.

@kallen-ledger kallen-ledger merged commit 12daa05 into develop Apr 5, 2024
55 checks passed
@kallen-ledger kallen-ledger deleted the bugfix/LIVE-11850 branch April 5, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants