-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix/LIVE-11850]: Add additional properties to the accepted & cancelled swap API calls. #6612
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
@@ -88,6 +100,7 @@ export default function ExchangeDrawer({ swapTransaction, exchangeRate, onComple | |||
}); | |||
setError(error); | |||
}, | |||
// eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we ignoring those deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding these dependencies will cause further renders which will then cause an error.
β Checklist
npx changeset
was attached.π Description
Add additional optional properties to the accepted & cancelled swap API calls.
For cancelled calls
and accepted calls
β Context
https://ledgerhq.atlassian.net/browse/LIVE-11850
π§ Checklist for the PR Reviewers