Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Feedback on #6609 #6613

Conversation

Philippoes
Copy link
Contributor

📝 Description

This PR addresses feedback from @sprohaszka-ledger on PR #6609

  • Remove the noop conditional in the claimOnClick button as the disabled property already handles that.
  • Directly reference platform/stakekit in Tron onClicks, as there are no other staking providers.
  • New changeset

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 2:13pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 2:13pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 2:13pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 2:13pm

@Philippoes Philippoes marked this pull request as ready for review April 4, 2024 14:12
@Philippoes Philippoes requested a review from a team as a code owner April 4, 2024 14:12
Copy link

vercel bot commented Apr 4, 2024

@Philippoes is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added desktop Has changes in LLD fork Pull request base branch comes from a fork. labels Apr 4, 2024
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it misses one check in the claimOnClick function.

@hedi-edelbloute hedi-edelbloute merged commit f0afbae into LedgerHQ:feat/enable-tron-staking-via-stakekit-backport Apr 5, 2024
16 of 17 checks passed
@Vin757
Copy link

Vin757 commented Apr 7, 2024

I don't know if I got it right. Hope I do

@live-github-bot
Copy link
Contributor

@Vin757 you are not part of the organization, please contact a maintainer if you need to run this command.

2 similar comments
@live-github-bot
Copy link
Contributor

@Vin757 you are not part of the organization, please contact a maintainer if you need to run this command.

@live-github-bot
Copy link
Contributor

@Vin757 you are not part of the organization, please contact a maintainer if you need to run this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD fork Pull request base branch comes from a fork.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants