Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E]: Fix Market test #6622

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[E2E]: Fix Market test #6622

merged 2 commits into from
Apr 5, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix E2E Market test screenshot failing

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested review from a team as code owners April 5, 2024 16:04
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 4:15pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 4:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 4:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 4:15pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 4:15pm

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Apr 5, 2024

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
βœ… - generate-screenshots-linux

@live-github-bot live-github-bot bot added desktop Has changes in LLD screenshots Screenshots have been updated labels Apr 5, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 6b41b3a into develop Apr 5, 2024
32 of 33 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the chore/fix-e2e-market branch April 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants