-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/live 10716 focus app when modal open #6632
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Ignored Deployments
|
797c027
to
6c50352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That solution will cover the scenario 1 but is not generic enough to work on all wallet-api call that requires a user action.
It would be good to do the logic in the wallet-api part so that we show LLD on any message that requires an action from the user.
useEffect(() => { | ||
ipcRenderer.send("ready-to-show", {}); | ||
}, []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to make our own show
handler on main because ready-to-show
will trigger a deeplink for windows and linux.
ipcMain.on("show", () => {
const w = getMainWindow();
if (w) {
show(w);
}
});
Also it would be good to do the logic in the wallet-api part so that we show LLD on any message that requires an action from the user
β Checklist
npx changeset
was attached.π Description
Focus on Ledger Live when modal opens
JIRA TICKET
β Context
π§ Checklist for the PR Reviewers