Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLD] - [LIVE-11842] - Remove the spams NFT in custom lock screen on LLD #6637

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[LLD] - [LIVE-11842] - Remove the spams NFT in custom lock screen on LLD #6637

merged 1 commit into from
Apr 10, 2024

Conversation

sshmaxime
Copy link
Contributor

@sshmaxime sshmaxime commented Apr 9, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This PR remove the spams NFT in custom lock screen on LLD.

Before:
Screenshot 2024-04-09 at 14 15 50

After:
Screenshot 2024-04-09 at 14 15 57

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@sshmaxime sshmaxime requested a review from a team as a code owner April 9, 2024 12:19
@vercel Vercel
Copy link

vercel bot commented Apr 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 1:36pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 1:36pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 1:36pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 1:36pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 1:36pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 9, 2024
ofreyssinet-ledger
ofreyssinet-ledger previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sshmaxime sshmaxime merged commit 9729140 into develop Apr 10, 2024
32 of 33 checks passed
@sshmaxime sshmaxime deleted the feat/LIVE-11842 branch April 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofreyssinet-ledger ofreyssinet-ledger ofreyssinet-ledger approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@sshmaxime sshmaxime

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sshmaxime @ofreyssinet-ledger @mcayuelas-ledger