Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-8183]LLM - MyLedger: hidden apps when using the search bar in the manager because of trimming #6640

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jiyuzhuang
Copy link
Contributor

@jiyuzhuang jiyuzhuang commented Apr 9, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • Trim search keyword to ensure that auto complete in mobile phone can find the correct answer.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jiyuzhuang jiyuzhuang added the live-devices Device team label label Apr 9, 2024
@jiyuzhuang jiyuzhuang self-assigned this Apr 9, 2024
@jiyuzhuang jiyuzhuang requested a review from a team as a code owner April 9, 2024 16:54
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 9, 2024 4:55pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 9, 2024 4:55pm
native-ui-storybook ⬜️ Ignored (Inspect) Apr 9, 2024 4:55pm
react-ui-storybook ⬜️ Ignored (Inspect) Apr 9, 2024 4:55pm
web-tools ⬜️ Ignored (Inspect) Apr 9, 2024 4:55pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Apr 9, 2024
@jiyuzhuang jiyuzhuang merged commit 928db7e into develop Apr 10, 2024
36 of 38 checks passed
@jiyuzhuang jiyuzhuang deleted the bugfix/LIVE-8183 branch April 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
live-devices Device team label mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants