Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] - [LIVE-11843] - Remove the spams NFT in custom lock screen on LLM #6659

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

sshmaxime
Copy link
Contributor

@sshmaxime sshmaxime commented Apr 11, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This PR removes the spams NFT in custom lock screen on LLM.

Before:
Screenshot 2024-04-11 at 13 54 53

After:
Screenshot 2024-04-11 at 13 55 05

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@sshmaxime sshmaxime requested a review from a team as a code owner April 11, 2024 12:11
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 11, 2024 0:12am
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 11, 2024 0:12am
native-ui-storybook ⬜️ Ignored (Inspect) Apr 11, 2024 0:12am
react-ui-storybook ⬜️ Ignored (Inspect) Apr 11, 2024 0:12am
web-tools ⬜️ Ignored (Inspect) Apr 11, 2024 0:12am

Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@sshmaxime sshmaxime merged commit 127fbdc into develop Apr 11, 2024
35 of 40 checks passed
@sshmaxime sshmaxime deleted the feat/LIVE-11843 branch April 11, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants