Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-12017][Onboarding][Stax]: Make update from <=1.3.0 unskippable #6662

Merged

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Apr 11, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM, LLD: Stax onboarding Early Security Checks

📝 Description

  • LLM update skippable (from a version > 1.3.0, here 1.4.0-rc2). Notice that the "Skip" button has been changed to a "shade" style to make it more discrete.

    llm-esc-fwupdate-skippable.mp4
  • LLM update unskippable (from a version <= 1.3.0, here 1.2.1-ilX)

    llm-esc-fwupdate-unskippable.mp4
  • LLD update skippable (from a version > 1.3.0, here 1.4.0-rc2). Notice that the "Skip" button has been changed to a "shade" style to make it more discrete.

    lld-esc-fwupdate-skippable.mov
  • LLD update unskippable (from a version <= 1.3.0, here 1.2.1-ilX)

    lld-esc-fwupdate-unskippable.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:44am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:44am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:44am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:44am
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:44am

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common labels Apr 11, 2024
Copy link

socket-security bot commented Apr 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jest/[email protected] Transitive: environment +12 888 kB simenb
npm/@types/[email protected] Transitive: environment +11 956 kB types
npm/@types/[email protected] None 0 6.67 kB types
npm/[email protected] None 0 11.7 kB sindresorhus
npm/[email protected] None +5 97.4 kB sindresorhus
npm/[email protected] None +2 398 kB andris
npm/[email protected] None 0 82.8 kB goto-bus-stop
npm/[email protected] Transitive: environment, filesystem +3 120 kB ryanzim
npm/[email protected] Transitive: environment +1 62.8 kB mridgway
npm/[email protected] None 0 11.9 kB jensyt
npm/[email protected] Transitive: environment +2 28.5 kB zertosh
npm/[email protected] None +3 358 kB atool
npm/[email protected] Transitive: environment, eval +48 6.19 MB samverschueren
npm/[email protected] None 0 1.41 MB bnjmnt4n
npm/[email protected] None 0 177 kB dcode
npm/[email protected] environment, filesystem 0 19.1 kB isaacs
npm/[email protected] None 0 4.23 MB ichernev
npm/[email protected] None 0 11.3 kB meryn
npm/[email protected] environment +4 145 kB ljharb
npm/[email protected] environment +3 4.62 MB gnoff
npm/[email protected] environment 0 24.8 kB gaearon
npm/[email protected] environment 0 23.7 kB acdlite
npm/[email protected] environment 0 58.7 kB gnoff
npm/[email protected] environment +6 1.77 MB gnoff
npm/[email protected] environment +2 337 kB gnoff
npm/[email protected] None 0 4.5 MB blesh
npm/[email protected] None +2 124 kB npm-cli-ops
npm/[email protected] None +2 125 kB npm-cli-ops
npm/[email protected] None +2 67.1 kB dcousens
npm/[email protected] filesystem +2 895 kB linusu
npm/[email protected] None 0 84 kB typescript-bot
npm/[email protected] None 0 116 kB ctavan
npm/[email protected] None 0 123 kB ctavan
npm/[email protected] environment, filesystem +13 625 kB oss-bot

🚮 Removed packages: npm/@actions/[email protected], npm/@actions/[email protected], npm/@actions/[email protected], npm/@aws-sdk/[email protected], npm/@azure/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@braze/[email protected], npm/@braze/[email protected], npm/@cardano-foundation/[email protected], npm/@celo/[email protected], npm/@celo/[email protected], npm/@celo/[email protected], npm/@celo/[email protected], npm/@celo/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@craftamap/[email protected], npm/@crypto-org-chain/[email protected], npm/@dfinity/[email protected], npm/@dfinity/[email protected], npm/@dfinity/[email protected], npm/@electron/[email protected], npm/@elrondnetwork/[email protected], npm/@elrondnetwork/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected]

View full report↗︎

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 11, 2024
@ofreyssinet-ledger ofreyssinet-ledger marked this pull request as ready for review April 11, 2024 16:21
@ofreyssinet-ledger ofreyssinet-ledger requested review from a team as code owners April 11, 2024 16:21
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@ofreyssinet-ledger ofreyssinet-ledger merged commit a13cc1a into develop Apr 12, 2024
55 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/LIVE-12017-esc-stax-unskippable-update-1.3.0 branch April 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants