Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: close completeExchange drawer when sell or card #6664

Merged
merged 3 commits into from
Apr 16, 2024
Merged

bugfix: close completeExchange drawer when sell or card #6664

merged 3 commits into from
Apr 16, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Apr 12, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

YOLO UNTESTED PR to call onClose when not in swap context

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner April 12, 2024 10:47
@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:42am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:42am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:42am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:42am
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 11:42am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 12, 2024
Justkant
Justkant requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we are missing the onClose in the array deps, making the CI red

@CremaFR CremaFR merged commit 0534fc3 into develop Apr 16, 2024
35 of 41 checks passed
@CremaFR CremaFR deleted the bugfix/close-drawer-cardsell branch April 16, 2024 16:04
CremaFR added a commit that referenced this pull request Apr 16, 2024
@CremaFR
bugfix: close completeExchange drawer when sell or card (#6664)
395687f 
* bugfix: close completeExchange drawer when sell or card

* chore: changeset

* chore: fix ci
@CremaFR CremaFR mentioned this pull request Apr 16, 2024
Merged
3 tasks
CremaFR added a commit that referenced this pull request Apr 16, 2024
@CremaFR
cherrypick: #6664 (#6693)
ba007c4 
bugfix: close completeExchange drawer when sell or card (#6664)

* bugfix: close completeExchange drawer when sell or card

* chore: changeset

* chore: fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justkant Justkant Justkant approved these changes

@cpellizzari-ledger cpellizzari-ledger cpellizzari-ledger approved these changes

Assignees

@CremaFR CremaFR

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CremaFR @Justkant @cpellizzari-ledger