[bugfix/LIVE-11512]: return correct translation for user refused on device from swap-live-app #6665
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
|
Generating screenshots: workflow ended Jobs status: |
cng-ledger
force-pushed
the
bugfix/LIVE-11512
branch
from
b5e0035
to
e051999
Compare
| @@ -733,18 +738,23 @@ export const renderError = ({ | |||
| withDescription?: boolean; | |||
| Icon?: (props: { color?: string | undefined; size?: number | undefined }) => JSX.Element; | |||
| }) => { | |||
| let tmpError = error; | |||
There was a problem hiding this comment.
I think it's about the line 752 to update the error type to a specific type. But you can do this after the first 3 assertions, it will be more clear. If the first 3 catches do not catch the error, then you do a check (error instanceof CompleteExchangeError && error.message === 'User refused') to see whether the error type needs an update.
There was a problem hiding this comment.
I believe this is correct, if we aren't doing any variable assignment at line 752, i can removed the let tmpError
| @@ -733,18 +738,23 @@ export const renderError = ({ | |||
| withDescription?: boolean; | |||
| Icon?: (props: { color?: string | undefined; size?: number | undefined }) => JSX.Element; | |||
| }) => { | |||
| let tmpError = error; | |||
There was a problem hiding this comment.
I believe this is correct, if we aren't doing any variable assignment at line 752, i can removed the let tmpError
✅ Checklist
npx changesetwas attached.📝 Description
return correct translation for user refused on device from swap-live-app
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-11512
🧐 Checklist for the PR Reviewers