-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡: [FEAT] - Add Spam report functionality in LLD #6667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
live-github-bot
bot
added
desktop
Has changes in LLD
translations
Translation files have been touched
labels
Apr 12, 2024
sshmaxime
reviewed
Apr 15, 2024
libs/live-nft/src/api/simplehash.ts
Outdated
url, | ||
headers: { | ||
accept: "application/json", | ||
"X-API-KEY": "sh_sk1_Z4jhWXXBE09em", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we get getEnv
the api key X-API-KEY
?
mcayuelas-ledger
force-pushed
the
feat/beta-nfts-spam-report
branch
2 times, most recently
from
April 15, 2024 08:15
3db2269
to
9442134
Compare
Contributor
Author
mcayuelas-ledger
force-pushed
the
feat/beta-nfts-spam-report
branch
from
April 16, 2024 10:52
94446fc
to
fe5d22e
Compare
live-github-bot
bot
added
common
Has changes in live-common
ledgerjs
Has changes in the ledgerjs open source libs
labels
Apr 16, 2024
KVNLS
previously approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common
Has changes in live-common
desktop
Has changes in LLD
ledgerjs
Has changes in the ledgerjs open source libs
translations
Translation files have been touched
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
To compensate for certain situations where NFTs do not appear in the Gallery because they are considered to be spam, they can now be marked as Non Spam.
It is also possible to mark an NFT and report it as Spam. Both are possible.
3 options :
Display of fields is conditioned with type of report you choose
Following SimpleHash doc (https://docs.simplehash.com/reference/send-spam-report)
Using also
useMutation
from Tanstack (https://tanstack.com/query/latest/docs/framework/react/reference/useMutation)Screen.Recording.2024-04-12.at.16.48.03.mov
Screen.Recording.2024-04-12.at.17.13.34.mov
FF demo
Screen.Recording.2024-04-16.at.13.58.21.mov
❓ Context
🧐 Checklist for the PR Reviewers