Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-12211][BREAKING CHANGE] Feature: Upgrade testnets to deprecate all Goerli networks #6669

Merged
merged 5 commits into from
Apr 18, 2024
Merged

[LIVE-12211][BREAKING CHANGE] Feature: Upgrade testnets to deprecate all Goerli networks #6669

merged 5 commits into from
Apr 18, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Apr 14, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • No impact as testnets + existing accounts will be automatically removed

📝 Description

  • Removal of previously supported currencies Ethereum Goerli, Ethereum Ropsten, Linea Goerli & Optimism Goerli
  • Adding support for Linea Sepolia & Optimism Sepolia

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lambertkevin lambertkevin requested review from a team as code owners April 14, 2024 14:55
@vercel Vercel
Copy link

vercel bot commented Apr 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 2:31pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 2:31pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 2:31pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 2:31pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 2:31pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs automation CI/CD stuff cli labels Apr 14, 2024
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch 2 times, most recently from 26044aa to 1b72bf8 Compare April 14, 2024 15:12
@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Apr 14, 2024
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from 1b72bf8 to 2a3757c Compare April 14, 2024 16:41
@lambertkevin lambertkevin changed the title [BREAKING CHANGE] Feature: Upgrade testnets to deprecate all Goerli networks [LIVE-12211][BREAKING CHANGE] Feature: Upgrade testnets to deprecate all Goerli networks Apr 15, 2024
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from a2cb484 to be18829 Compare April 15, 2024 17:31
lvndry
lvndry previously approved these changes Apr 16, 2024
View reviewed changes
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from be18829 to 65aa4ed Compare April 16, 2024 15:30
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from 65aa4ed to 8572aa2 Compare April 17, 2024 15:48
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from 8572aa2 to 3a62da3 Compare April 17, 2024 17:06
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from 3a62da3 to 2f0b05e Compare April 18, 2024 08:23
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from 2f0b05e to 12c9e93 Compare April 18, 2024 10:56
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from 12c9e93 to 165e061 Compare April 18, 2024 11:00
@lambertkevin lambertkevin force-pushed the feature/upgrade-testnets-to-deprecate-goerli branch from 165e061 to 0537dd7 Compare April 18, 2024 14:29
@lambertkevin lambertkevin merged commit fdb76a7 into develop Apr 18, 2024
57 of 63 checks passed
@lambertkevin lambertkevin deleted the feature/upgrade-testnets-to-deprecate-goerli branch April 18, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvndry lvndry lvndry left review comments

Assignees

@lambertkevin lambertkevin

Labels
automation CI/CD stuff cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lambertkevin @lvndry