Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): fix ui select device screen #6670

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Apr 15, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix ui problem caused by a previous PR : feat/LIVE-11955
When no CC is displayed, the CTA Select device is in the middle of the screen instead of at the top.

Before After
image image

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner April 15, 2024 09:34
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 15, 2024 9:35am
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 15, 2024 9:35am
native-ui-storybook ⬜️ Ignored (Inspect) Apr 15, 2024 9:35am
react-ui-storybook ⬜️ Ignored (Inspect) Apr 15, 2024 9:35am
web-tools ⬜️ Ignored (Inspect) Apr 15, 2024 9:35am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Apr 15, 2024
@LucasWerey LucasWerey merged commit f411a5b into develop Apr 15, 2024
35 of 37 checks passed
@LucasWerey LucasWerey deleted the fix/select-device-screen branch April 15, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants