[feat/LIVE-12118]: add buy sell ui flag to enable progressive replacement of multibuy-v2 live app #6686

beths-ledger · 2024-04-16T14:51:23Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- Find flag in settings: buySellUi
- It should toggle on/off, but also accept params json: { "params": { "manifestId": "buy-sell-ui" } }
- when using manifestId "buy-sell-ui", the URL for buy/sell live app should change to https://buy-sell.ledger.com
- Other functionality should remain the same.

📝 Description

add buy sell ui flag to enable progressive replacement of multibuy-v2 live app
when flag is enabled, option to use "buy-sell-ui" manifest id instead of "multibuy-v2" (or to override with a custom staging manifest id)
allow multibuy logic to apply for either buy-sell manifest

❓ Context

JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/LIVE-12118

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-16T14:51:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2024 3:14pm

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Apr 19, 2024 3:14pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Apr 19, 2024 3:14pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Apr 19, 2024 3:14pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Apr 19, 2024 3:14pm

beths-ledger · 2024-04-17T16:18:06Z

@beths-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

cksanders · 2024-04-18T09:49:45Z

libs/ledgerjs/packages/types-live/src/feature.ts

@@ -461,6 +462,7 @@ export type Feature_LldRefreshMarketData = Feature<{

 export type Feature_CounterValue = DefaultFeature;
 export type Feature_MockFeature = DefaultFeature;
+export type Feature_BuySellUi = DefaultFeature;


Suggested change

export type Feature_BuySellUi = DefaultFeature;

export type Feature_BuySellUI = DefaultFeature;

Although I agree, I am hesitant to capitalise as the other flags seem to consistently use full camelCase e.g. llmFeature etc

cksanders · 2024-04-18T09:53:05Z

apps/ledger-live-desktop/src/renderer/screens/exchange/index.tsx

@@ -105,7 +107,9 @@ export type ExchangeComponentParams = {

 const Exchange = ({ match }: RouteComponentProps<ExchangeComponentParams>) => {
  const appId = match?.params?.appId;
+  const buySellUiFlag = useFeature("buySellUi");


I'd rename this to be a little clearer for other developers ... explaining that this is a rollout on v3 of Buy Sell FE, maybe something like buySellUIV3

if we make the manifest id extendable then the version could be anything rather than always 3, so it might be best to avoid using the version actually..

cgrellard-ledger · 2024-04-19T09:13:01Z

apps/ledger-live-mobile/src/navigation/DeeplinksProvider.tsx

@@ -71,7 +74,7 @@ function getProxyURL(url: string) {
  // This is to handle links set in the useFromAmountStatusMessage in LLC.
  // Also handles a difference in paths between LLD on LLD /platform/:app_id
  // but on LLM /discover/:app_id
-  if (hostname === "platform" && [DEFAULT_MULTIBUY_APP_ID].includes(platform)) {
+  if (hostname === "platform" && [DEFAULT_MULTIBUY_APP_ID, BUY_SELL_UI_APP_ID].includes(platform)) {


Here do we want to add the buySellUiFlag.params.manifestId in the array ?

Yes for completion, good plan, added! Thanks!

beths-ledger · 2024-04-19T14:52:47Z

@beths-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

ComradeAERGO

Looking good to me
Pinging @Justkant for reference when he comes back from holiday

mitchellv-ledger

LGTM

beths-ledger requested review from a team as code owners April 16, 2024 14:51

github-actions bot assigned beths-ledger Apr 16, 2024

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Apr 16, 2024

vercel bot deployed to Preview – web-tools April 16, 2024 14:55 View deployment

beths-ledger requested a review from cksanders April 16, 2024 15:01

beths-ledger force-pushed the feat/enable-buy-sell-ui-feature-flag branch from 28be9e2 to 44351a9 Compare April 17, 2024 16:15

vercel bot deployed to Preview – web-tools April 17, 2024 16:20 View deployment

mcayuelas-ledger previously approved these changes Apr 18, 2024

View reviewed changes

cksanders reviewed Apr 18, 2024

View reviewed changes

Justkant previously approved these changes Apr 18, 2024

View reviewed changes

beths-ledger dismissed stale reviews from Justkant and mcayuelas-ledger via 3395b39 April 18, 2024 15:18

vercel bot deployed to Preview – web-tools April 18, 2024 15:24 View deployment

Justkant previously approved these changes Apr 18, 2024

View reviewed changes

beths-ledger dismissed Justkant’s stale review via 935a1b3 April 18, 2024 16:47

beths-ledger requested review from Justkant and mcayuelas-ledger April 19, 2024 08:47

cgrellard-ledger reviewed Apr 19, 2024

View reviewed changes

mohammed-ledger previously approved these changes Apr 19, 2024

View reviewed changes

beths-ledger dismissed mohammed-ledger’s stale review via 9c758fb April 19, 2024 09:53

beths-ledger requested review from cgrellard-ledger and mohammed-ledger April 19, 2024 09:53

beths-ledger force-pushed the feat/enable-buy-sell-ui-feature-flag branch from 9c758fb to 6101188 Compare April 19, 2024 09:56

cgrellard-ledger previously approved these changes Apr 19, 2024

View reviewed changes

beths-ledger dismissed cgrellard-ledger’s stale review via 7d797e6 April 19, 2024 10:02

beths-ledger force-pushed the feat/enable-buy-sell-ui-feature-flag branch from 6101188 to 7d797e6 Compare April 19, 2024 10:02

mohammed-ledger previously approved these changes Apr 19, 2024

View reviewed changes

beths-ledger added 4 commits April 19, 2024 11:24

feat: add buy sell ui flag, include buy sell ui next to multibuy logic

2a034d8

refactor: accept manifest id in feature flag

e5d2573

refactor: feature flag params types

e8104e7

refactor: add manifest id to deeplinks listener

0d31252

beths-ledger force-pushed the feat/enable-buy-sell-ui-feature-flag branch from 7d797e6 to 0d31252 Compare April 19, 2024 10:24

refactor: create reusable internal app ids hook

d99742b

beths-ledger dismissed mohammed-ledger’s stale review via 8c1b9d9 April 19, 2024 14:27

refactor: use hook in mobile webviews

11592fe

beths-ledger force-pushed the feat/enable-buy-sell-ui-feature-flag branch from 8c1b9d9 to 11592fe Compare April 19, 2024 14:28

refactor: add fallback consts in case flags do not load

d3b4a86

chore: add hook to unimported entry array

ba26a05

beths-ledger requested review from mohammed-ledger and cgrellard-ledger April 19, 2024 15:11

vercel bot deployed to Preview – web-tools April 19, 2024 15:14 View deployment

mohammed-ledger approved these changes Apr 19, 2024

View reviewed changes

ComradeAERGO approved these changes Apr 22, 2024

View reviewed changes

beths-ledger requested a review from a team April 22, 2024 09:07

gre approved these changes Apr 22, 2024

View reviewed changes

mitchellv-ledger approved these changes Apr 22, 2024

View reviewed changes

beths-ledger merged commit 1b17628 into develop Apr 22, 2024
55 of 57 checks passed

beths-ledger deleted the feat/enable-buy-sell-ui-feature-flag branch April 22, 2024 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat/LIVE-12118]: add buy sell ui flag to enable progressive replacement of multibuy-v2 live app #6686

[feat/LIVE-12118]: add buy sell ui flag to enable progressive replacement of multibuy-v2 live app #6686

beths-ledger commented Apr 16, 2024 •

edited

Loading

vercel bot commented Apr 16, 2024 •

edited

Loading

beths-ledger commented Apr 17, 2024 •

edited by live-github-bot bot

Loading

cksanders Apr 18, 2024

beths-ledger Apr 19, 2024

cksanders Apr 18, 2024

beths-ledger Apr 18, 2024

cgrellard-ledger Apr 19, 2024

beths-ledger Apr 19, 2024 •

edited

Loading

beths-ledger commented Apr 19, 2024 •

edited by live-github-bot bot

Loading

ComradeAERGO left a comment

mitchellv-ledger left a comment

	export type Feature_BuySellUi = DefaultFeature;
	export type Feature_BuySellUI = DefaultFeature;

[feat/LIVE-12118]: add buy sell ui flag to enable progressive replacement of multibuy-v2 live app #6686

[feat/LIVE-12118]: add buy sell ui flag to enable progressive replacement of multibuy-v2 live app #6686

Conversation

beths-ledger commented Apr 16, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 16, 2024 • edited Loading

beths-ledger commented Apr 17, 2024 • edited by live-github-bot bot Loading

cksanders Apr 18, 2024

Choose a reason for hiding this comment

beths-ledger Apr 19, 2024

Choose a reason for hiding this comment

cksanders Apr 18, 2024

Choose a reason for hiding this comment

beths-ledger Apr 18, 2024

Choose a reason for hiding this comment

cgrellard-ledger Apr 19, 2024

Choose a reason for hiding this comment

beths-ledger Apr 19, 2024 • edited Loading

Choose a reason for hiding this comment

beths-ledger commented Apr 19, 2024 • edited by live-github-bot bot Loading

ComradeAERGO left a comment

Choose a reason for hiding this comment

mitchellv-ledger left a comment

Choose a reason for hiding this comment

beths-ledger commented Apr 16, 2024 •

edited

Loading

vercel bot commented Apr 16, 2024 •

edited

Loading

beths-ledger commented Apr 17, 2024 •

edited by live-github-bot bot

Loading

beths-ledger Apr 19, 2024 •

edited

Loading

beths-ledger commented Apr 19, 2024 •

edited by live-github-bot bot

Loading