Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: untranslated CTA [LIVE-11648] #6690

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

RamyEB
Copy link
Contributor

@RamyEB RamyEB commented Apr 16, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix untranslated cta on LLM
LIVE TICKET

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@RamyEB RamyEB requested review from a team as code owners April 16, 2024 15:43
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 3:49pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 3:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 3:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 3:49pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Apr 16, 2024
@RamyEB RamyEB force-pushed the fix/LIVE-11648-fix-untranslated-cta branch from 5292310 to c20be8b Compare April 16, 2024 15:43
@live-github-bot live-github-bot bot removed desktop Has changes in LLD translations Translation files have been touched labels Apr 16, 2024
Copy link

vercel bot commented Apr 16, 2024

Deployment failed with the following error:

Too many requests - try again in 34 seconds (more than 60, code: "api-deployments-flood").

@Justkant Justkant changed the title Fix/live-11648-fix-untranslated-cta fix: untranslated CTA [LIVE-11648] Apr 16, 2024
@RamyEB RamyEB merged commit 8dbb76b into develop Apr 17, 2024
31 of 38 checks passed
@RamyEB RamyEB deleted the fix/LIVE-11648-fix-untranslated-cta branch April 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants