Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM/LLD] Deprecated coins banner #6692

Merged
merged 19 commits into from
Apr 23, 2024
Merged

[LLM/LLD] Deprecated coins banner #6692

merged 19 commits into from
Apr 23, 2024

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Apr 16, 2024

❓ Context

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLD: when "will_be_deprecated" coin config is on, a banner should be displayed
    • LLM: when "will_be_deprecated" coin config is on, a banner should be displayed

📝 Description

We add a banner in the account page to inform users a coin is about to be deprecated

Screenshot 2024-04-17 at 13 15 27 Screenshot 2024-04-17 at 13 21 26 Screenshot 2024-04-17 at 13 20 38

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lvndry lvndry self-assigned this Apr 16, 2024
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:43pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:43pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:43pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:43pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:43pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common mobile Has changes in LLM translations Translation files have been touched labels Apr 16, 2024
@lvndry lvndry changed the title Deprecated coins banner [LLM/LLD] Deprecated coins banner Apr 17, 2024
@lvndry lvndry marked this pull request as ready for review April 17, 2024 11:16
@lvndry lvndry requested review from a team as code owners April 17, 2024 11:16
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at my comments, plz.
Thanks

hzheng-ledger
hzheng-ledger previously approved these changes Apr 22, 2024
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks

Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lvndry lvndry merged commit 3896648 into develop Apr 23, 2024
54 of 60 checks passed
@lvndry lvndry deleted the deprecated-coins-banner branch April 23, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants