Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PROTECT-3040): fix stax recover source & enable #6695

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

cksanders
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

PR to enable stax on onboarding via recover & set the correct deeplink source for lld.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cksanders cksanders requested review from a team as code owners April 16, 2024 16:44
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 16, 2024 4:44pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 16, 2024 4:44pm
native-ui-storybook ⬜️ Ignored (Inspect) Apr 16, 2024 4:44pm
react-ui-storybook ⬜️ Ignored (Inspect) Apr 16, 2024 4:44pm
web-tools ⬜️ Ignored (Inspect) Apr 16, 2024 4:44pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 16, 2024
@cksanders cksanders merged commit 601f493 into develop Apr 17, 2024
34 checks passed
@cksanders cksanders deleted the feat/PROTECT-3040/stax-deeplinks branch April 17, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants