Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA Tokens add account translations #6697

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Apr 17, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Add translations for addAccounts > tokens > asa

Before

image

After
Screenshot 2024-04-17 at 15 42 57

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lvndry lvndry self-assigned this Apr 17, 2024
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 17, 2024 1:43pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 17, 2024 1:43pm
native-ui-storybook ⬜️ Ignored (Inspect) Apr 17, 2024 1:43pm
react-ui-storybook ⬜️ Ignored (Inspect) Apr 17, 2024 1:43pm
web-tools ⬜️ Ignored (Inspect) Apr 17, 2024 1:43pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Apr 17, 2024
@lvndry lvndry marked this pull request as ready for review April 17, 2024 13:43
@lvndry lvndry requested a review from a team April 17, 2024 13:49
@lvndry lvndry merged commit 82c537e into develop Apr 19, 2024
34 of 40 checks passed
@lvndry lvndry deleted the feat/live-11856-asa-tokens-translation branch April 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants