-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π [LIVE-12015] [LLD/LLM] Prevent the screen from locking for firmware update and app installation/update #6698
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Ignored Deployments
|
78ab3f6
to
f228e9e
Compare
f228e9e
to
c53b057
Compare
a005542
to
aceac7d
Compare
|
||
const activateKeepAwake = useCallback(async () => { | ||
if (Number.isNaN(blockerId.current)) { | ||
blockerId.current = await ipcRenderer.invoke("activate-keep-screen-awake"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SHOULD] Use constants for the string key (ie: "activate-keep-screen-awake" and "deactivate-keep-screen-awake")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ipc message is defined and used this way in main/setup.ts
actually
c1e1292
to
7a564e3
Compare
b2c70fb
to
80335ee
Compare
apps/ledger-live-desktop/src/renderer/screens/manager/FirmwareUpdate/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/screens/manager/FirmwareUpdate/index.tsx
Outdated
Show resolved
Hide resolved
80335ee
to
167e189
Compare
apps/ledger-live-desktop/src/renderer/screens/manager/FirmwareUpdate/index.tsx
Outdated
Show resolved
Hide resolved
167e189
to
95e152a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
95e152a
to
452cf23
Compare
Wiz Scan Summary
|
- App install inside My Ledger - Firmware Update - Inline App install => DeviceAction Component - Sync Onboarding
- App install inside My Ledger - Firmware Update - Inline App install => DeviceAction Component - Sync Onboarding
452cf23
to
21c196d
Compare
β Checklist
npx changeset
was attached.π Description
Prevent the screen from locking for firmware update and app installation/update
β Context
π§ Checklist for the PR Reviewers