Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ : Fix Explorer Button in NFT viewer #6700

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

Before
Screenshot 2024-04-17 at 17 54 59

After

Screenshot 2024-04-17 at 17 51 00 Screenshot 2024-04-17 at 17 50 42

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner April 17, 2024 15:56
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 8:19am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 8:19am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 8:19am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 8:19am
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 8:19am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 17, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit ac986be into develop Apr 18, 2024
32 of 33 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the fix/fix-nft-viewer branch April 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants