Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 (lld/llm) [12240] Copy for recover during onboarding flow to be updated to latest version #6709

Merged
merged 3 commits into from
Apr 22, 2024
Merged

💄 (lld/llm) [12240] Copy for recover during onboarding flow to be updated to latest version #6709

merged 3 commits into from
Apr 22, 2024

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Apr 18, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Copy for recover during onboarding flow to be updated to latest version

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)
live-12240.mp4

@jdabbech-ledger jdabbech-ledger added the live-devices Device team label label Apr 18, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:54pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:54pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:54pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:54pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:54pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Apr 18, 2024
@jdabbech-ledger jdabbech-ledger marked this pull request as ready for review April 18, 2024 09:09
@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner April 18, 2024 09:09
@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12240-backup-companion-reviews branch from a5a93c2 to 91106a2 Compare April 18, 2024 09:10
@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12240-backup-companion-reviews branch from 91106a2 to 9870792 Compare April 18, 2024 14:34
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 18, 2024
@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12240-backup-companion-reviews branch from 9870792 to c745a62 Compare April 18, 2024 14:35
@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from 91b8256 to 39278f3 Compare April 18, 2024 14:59
@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner April 18, 2024 14:59
@jdabbech-ledger jdabbech-ledger changed the base branch from feat/LIVE-12107-lld-synconboarding-recover-backup to develop April 18, 2024 14:59
@jdabbech-ledger jdabbech-ledger dismissed mcayuelas-ledger’s stale review April 18, 2024 14:59

The base branch was changed.

@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12240-backup-companion-reviews branch from c745a62 to 592f322 Compare April 18, 2024 15:11
@live-github-bot live-github-bot bot added common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs labels Apr 18, 2024
@jdabbech-ledger jdabbech-ledger changed the base branch from develop to feat/LIVE-12107-lld-synconboarding-recover-backup April 18, 2024 15:13
@jdabbech-ledger jdabbech-ledger changed the title 💬 (llm) [12240] Copy for recover during onboarding flow to be updated to latest version 💬 (lld/llm) [12240] Copy for recover during onboarding flow to be updated to latest version Apr 18, 2024
@jdabbech-ledger jdabbech-ledger changed the title 💬 (lld/llm) [12240] Copy for recover during onboarding flow to be updated to latest version 💄 (lld/llm) [12240] Copy for recover during onboarding flow to be updated to latest version Apr 18, 2024
@mbertin-ledger mbertin-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from 5a89aed to 5fdf0ee Compare April 19, 2024 08:49
@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12240-backup-companion-reviews branch from 592f322 to 0ae4985 Compare April 19, 2024 08:58
@live-github-bot live-github-bot bot removed common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs labels Apr 19, 2024
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from fe444bc to 8de9da1 Compare April 22, 2024 10:44
@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12240-backup-companion-reviews branch from 0ae4985 to 2ea22ad Compare April 22, 2024 13:51
@live-github-bot live-github-bot bot added common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs labels Apr 22, 2024
@jdabbech-ledger jdabbech-ledger force-pushed the feat/LIVE-12240-backup-companion-reviews branch from 2ea22ad to 7f5fb20 Compare April 22, 2024 13:52
@live-github-bot live-github-bot bot removed common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs labels Apr 22, 2024
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from f558546 to a0f2dfa Compare April 22, 2024 13:56
@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner April 22, 2024 13:56
@jdabbech-ledger jdabbech-ledger merged commit 7dda085 into feat/LIVE-12107-lld-synconboarding-recover-backup Apr 22, 2024
39 of 42 checks passed
@jdabbech-ledger jdabbech-ledger deleted the feat/LIVE-12240-backup-companion-reviews branch April 22, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbertin-ledger mbertin-ledger mbertin-ledger approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

Assignees

@jdabbech-ledger jdabbech-ledger

Labels
desktop Has changes in LLD live-devices Device team label mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdabbech-ledger @mbertin-ledger @mcayuelas-ledger