[LIVE-9354] Device renaming: Nano SP supported #6733

ofreyssinet-ledger · 2024-04-23T15:47:39Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- LLM+LLD: Device renaming for LNSP on LLM

📝 Description

Device renaming is supported by Nano S Plus devices.

❓ Context

JIRA or GitHub link: LIVE-9354

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-23T15:47:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Apr 25, 2024 7:47am
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Apr 25, 2024 7:47am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Apr 25, 2024 7:47am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Apr 25, 2024 7:47am
web-tools	⬜️ Ignored (Inspect)	Visit Preview	Apr 25, 2024 7:47am

ofreyssinet-ledger · 2024-04-24T08:12:27Z

@ofreyssinet-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

ofreyssinet-ledger · 2024-04-24T13:47:04Z

apps/ledger-live-mobile/src/screens/MyLedgerDevice/index.tsx

@@ -46,7 +46,8 @@ const Manager = ({ navigation, route }: NavigationProps) => {
    tab = "CATALOG",
  } = route.params;

-  const { deviceId, deviceName, modelId } = device;


deviceName here is the name exposed by the transport (so BLE only)

ofreyssinet-ledger · 2024-04-24T13:47:45Z

apps/ledger-live-mobile/src/screens/MyLedgerDevice/index.tsx

@@ -46,7 +46,8 @@ const Manager = ({ navigation, route }: NavigationProps) => {
    tab = "CATALOG",
  } = route.params;

-  const { deviceId, deviceName, modelId } = device;
+  const { deviceId, modelId } = device;
+  const { deviceName } = result;


this deviceName is the result of the getDeviceName command (in the list apps task), which will work in all cases (BLE but also USB)

vercel · 2024-04-24T15:03:08Z

Deployment failed with the following error:

Too many requests - try again in 2 minutes (more than 60, code: "api-deployments-flood").

aussedatlo

LGTM 👍

…f truth + fix edit

because the name displayed in My Ledger no longer comes from device object but from result of getDeviceName command

…rwise product name

Vin757 · 2024-04-25T09:11:28Z

Hope it fix and remove the issue

live-github-bot · 2024-04-25T09:11:30Z

@Vin757 you are not part of the organization, please contact a maintainer if you need to run this command.

live-github-bot · 2024-04-25T09:11:33Z

@Vin757 you are not part of the organization, please contact a maintainer if you need to run this command.

live-github-bot · 2024-04-25T09:11:36Z

@Vin757 you are not part of the organization, please contact a maintainer if you need to run this command.

live-github-bot · 2024-04-25T09:11:39Z

@Vin757 you are not part of the organization, please contact a maintainer if you need to run this command.

github-actions bot assigned ofreyssinet-ledger Apr 23, 2024

vercel bot deployed to Preview – web-tools April 23, 2024 15:51 View deployment

ofreyssinet-ledger requested a review from a team as a code owner April 23, 2024 15:57

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Apr 23, 2024

vercel bot deployed to Preview – web-tools April 23, 2024 16:01 View deployment

ofreyssinet-ledger changed the title ~~[LIVE-9354] Device renaming: Nano SP supported~~ [LIVE-9354] Device renaming: Nano S & SP supported Apr 23, 2024

vercel bot deployed to Preview – web-tools April 23, 2024 16:14 View deployment

ofreyssinet-ledger requested review from a team as code owners April 24, 2024 08:19

live-github-bot bot added the screenshots Screenshots have been updated label Apr 24, 2024

ofreyssinet-ledger force-pushed the bugfix/LIVE-9354-device-renaming-lnsp branch from d4e8882 to b30f2ff Compare April 24, 2024 11:50

ofreyssinet-ledger commented Apr 24, 2024

View reviewed changes

ofreyssinet-ledger changed the title ~~[LIVE-9354] Device renaming: Nano S & SP supported~~ [LIVE-9354] Device renaming: Nano SP supported Apr 24, 2024

aussedatlo approved these changes Apr 24, 2024

View reviewed changes

ofreyssinet-ledger and others added 9 commits April 25, 2024 09:46

fix(device-core/isEditDeviceNameSupported): Nano SP supported

bfca25b

fix(device-core/isEditDeviceNameSupported): Nano S supported

a01b1e7

test(device-core/isEditDeviceNameSupported): add test case

7fdbe08

test(lld): update screenshots (ubuntu-latest) lld, test, screenshot

6e17a3e

fix(llm/myledger): take device name from list apps result as source o…

9d4db8c

…f truth + fix edit

style(llm): lint

a119772

test(llm/e2e): fix mock device name

5672cca

because the name displayed in My Ledger no longer comes from device object but from result of getDeviceName command

fix(device-core): revert Nano S support for device renaming

2e7735d

fix(llm/DeviceName): display device name only if edit supported, othe…

c0a0f3f

…rwise product name

ofreyssinet-ledger force-pushed the bugfix/LIVE-9354-device-renaming-lnsp branch from bc34ea4 to c0a0f3f Compare April 25, 2024 07:46

valpinkman approved these changes Apr 25, 2024

View reviewed changes

gre approved these changes Apr 25, 2024

View reviewed changes

ofreyssinet-ledger merged commit b86a1e0 into develop Apr 25, 2024
55 of 56 checks passed

ofreyssinet-ledger deleted the bugfix/LIVE-9354-device-renaming-lnsp branch April 25, 2024 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LIVE-9354] Device renaming: Nano SP supported #6733

[LIVE-9354] Device renaming: Nano SP supported #6733

ofreyssinet-ledger commented Apr 23, 2024 •

edited

Loading

vercel bot commented Apr 23, 2024 •

edited

Loading

ofreyssinet-ledger commented Apr 24, 2024 •

edited by live-github-bot bot

Loading

ofreyssinet-ledger Apr 24, 2024 •

edited

Loading

ofreyssinet-ledger Apr 24, 2024

vercel bot commented Apr 24, 2024

aussedatlo left a comment

Vin757 commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

[LIVE-9354] Device renaming: Nano SP supported #6733

[LIVE-9354] Device renaming: Nano SP supported #6733

Conversation

ofreyssinet-ledger commented Apr 23, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 23, 2024 • edited Loading

ofreyssinet-ledger commented Apr 24, 2024 • edited by live-github-bot bot Loading

ofreyssinet-ledger Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

ofreyssinet-ledger Apr 24, 2024

Choose a reason for hiding this comment

vercel bot commented Apr 24, 2024

aussedatlo left a comment

Choose a reason for hiding this comment

Vin757 commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

live-github-bot bot commented Apr 25, 2024

ofreyssinet-ledger commented Apr 23, 2024 •

edited

Loading

vercel bot commented Apr 23, 2024 •

edited

Loading

ofreyssinet-ledger commented Apr 24, 2024 •

edited by live-github-bot bot

Loading

ofreyssinet-ledger Apr 24, 2024 •

edited

Loading