Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PROTECT-3040): capture device model id in recover #6760

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

cksanders
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This PR is to ensure we capture the device & model id and send this to the Recover webview, so that Recover can send the correct device analytics to segment, and ultimately mixpanel.

We mustn't mix up deviceId and deviceModelId, as they both have different internal meanings/references.

In LLD, when the device is connected via a cable then deviceId is empty & deviceModelId is required, but in LLM no cable is required and deviceId is used.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cksanders cksanders requested review from a team as code owners April 26, 2024 08:22
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 26, 2024 8:22am
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 26, 2024 8:22am
native-ui-storybook ⬜️ Ignored (Inspect) Apr 26, 2024 8:22am
react-ui-storybook ⬜️ Ignored (Inspect) Apr 26, 2024 8:22am
web-tools ⬜️ Ignored (Inspect) Apr 26, 2024 8:22am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Apr 26, 2024
@cksanders cksanders merged commit 987feb2 into release Apr 26, 2024
50 of 52 checks passed
@cksanders cksanders deleted the feat/PROTECT-3040/send-device-id branch April 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants