[LIVE-11184][Europa] Firmware update support #6775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
ofreyssinet-ledger
force-pushed
the
feat/europa-fw-update
branch
from
904124e
to
9b340e8
Compare
There was a problem hiding this comment.
just a small refacto here, for improved readability
| @@ -166,7 +166,6 @@ const EarlySecurityChecks = ({ | |||
| closeFwUpdateDrawer(); | |||
| restartChecksAfterUpdate(); | |||
| }, | |||
| deviceHasPin: deviceModelId !== DeviceModelId.stax, // early security checks are triggered only if the device is in one of the steps prior to setting a PIN code | |||
There was a problem hiding this comment.
this prop gets overridden so it's useless here
smartine-ledger
approved these changes
May 2, 2024
LucasWerey
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Some fixes necessary to fully support firmware updates of Europa via LLM & LLD:
device-core: the minimum supported version forisBootloaderVersionSupportedandisDeviceLocalizationSupportedwere incorrect for Europa, which led to an incorrect parsing of thegetVersionresponse:LLD: the "restore" step of the firmware update was only added for devices supporting device localisation. It should also take into account support of custom lock screen. Given the issue listed previously, Europa was considered as not supporting localisation, therefore highlighting this issue because the restore step was missing, and the update flow broken.❓ Context
🧐 Checklist for the PR Reviewers