-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: LLM currency unit settings + drop all remaining usage of Account#unit #6791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
live-github-bot
bot
added
desktop
Has changes in LLD
mobile
Has changes in LLM
common
Has changes in live-common
ledgerjs
Has changes in the ledgerjs open source libs
cli
labels
Apr 30, 2024
gre
commented
Apr 30, 2024
gre
force-pushed
the
support/account-name-lldunit
branch
from
May 2, 2024 08:00
74717c4
to
e9c8c82
Compare
Closed
3 tasks
3 tasks
gre
force-pushed
the
support/account-name-all-unit
branch
from
May 2, 2024 08:23
bcb037c
to
6928ae3
Compare
the PR is moving to #6796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
Replace usage of Account#unit in LLM to a new per currency settings.
all remaining usages of account.unit in live-common and cli where a mistake and we always wanted to do
getAccountCurrency(account).units[0]
for them, notably they are for two usecases:β Context
π§ Checklist for the PR Reviewers