Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(PROTECT-3040): recover webview does not reload on device disconnect #6801

Merged
merged 1 commit into from
May 6, 2024

Conversation

cksanders
Copy link
Contributor

@cksanders cksanders commented May 2, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Given a user is on the Recover Live App and disconnects or reconnects their device via a cable, the Recover Web Player will reload due to the useMemo dependencies. This PR is to remove deviceModelId from the dependency list to ensure no reload on reconnecting via cable.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cksanders cksanders requested a review from a team as a code owner May 2, 2024 11:05
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) May 2, 2024 11:05am
ledger-live-github-bot ⬜️ Ignored (Inspect) May 2, 2024 11:05am
native-ui-storybook ⬜️ Ignored (Inspect) May 2, 2024 11:05am
react-ui-storybook ⬜️ Ignored (Inspect) May 2, 2024 11:05am
web-tools ⬜️ Ignored (Inspect) May 2, 2024 11:05am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 2, 2024
@desirendr desirendr merged commit 9f31934 into release May 6, 2024
33 of 36 checks passed
@desirendr desirendr deleted the bugfix/PROTECT-3040/model-id branch May 6, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants